Skip to content

Require metadata on server discover requests#244

Closed
leehack wants to merge 3 commits into
spec/json-rpc-integer-ids-progress-tokensfrom
spec/discover-request-meta-validation
Closed

Require metadata on server discover requests#244
leehack wants to merge 3 commits into
spec/json-rpc-integer-ids-progress-tokensfrom
spec/discover-request-meta-validation

Conversation

@leehack
Copy link
Copy Markdown
Owner

@leehack leehack commented Jun 1, 2026

Summary

  • require server/discover requests to carry nested params._meta request metadata when parsing or serializing
  • reject top-level-only or missing metadata for the 2026 discover request shape
  • add a CLI conformance case for the server/discover request metadata requirement

Verification

  • dart format lib/src/types/initialization.dart test/mcp_2026_07_28_test.dart packages/mcp_dart_cli/lib/src/conformance_runner.dart packages/mcp_dart_cli/test/src/conformance_command_test.dart
  • dart test test/mcp_2026_07_28_test.dart
  • (cd packages/mcp_dart_cli && dart test test/src/conformance_command_test.dart)
  • (cd packages/mcp_dart_cli && dart run mcp_dart_cli:mcp_dart conformance --suite all --json)
  • dart analyze
  • git diff --check
  • (cd packages/mcp_dart_cli && dart analyze)
  • dart test
  • (cd packages/mcp_dart_cli && dart test)

Spec note: the current draft schema requires server/discover to include params, and common request params require _meta. This remains draft-stack work while 2026-07-28 is RC.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.45%. Comparing base (126d245) to head (f13ede6).

Additional details and impacted files
@@                              Coverage Diff                              @@
##           spec/json-rpc-integer-ids-progress-tokens     #244      +/-   ##
=============================================================================
+ Coverage                                      88.43%   88.45%   +0.01%     
=============================================================================
  Files                                             47       47              
  Lines                                           9325     9338      +13     
=============================================================================
+ Hits                                            8247     8260      +13     
  Misses                                          1078     1078              
Flag Coverage Δ
unittests 88.45% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@leehack
Copy link
Copy Markdown
Owner Author

leehack commented Jun 1, 2026

Closing this draft micro PR because the RC spec work has been consolidated into a smaller reviewable stack. This change is preserved in #270 (JSON-RPC metadata hardening); the consolidated tip is tree-identical to the previous micro-stack tip.

@leehack leehack closed this Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant