Skip to content

Validate JSON-RPC error object wire values#240

Closed
leehack wants to merge 1 commit into
spec/json-rpc-method-wire-validationfrom
spec/json-rpc-error-object-validation
Closed

Validate JSON-RPC error object wire values#240
leehack wants to merge 1 commit into
spec/json-rpc-method-wire-validationfrom
spec/json-rpc-error-object-validation

Conversation

@leehack
Copy link
Copy Markdown
Owner

@leehack leehack commented Jun 1, 2026

Summary

  • Validate JSON-RPC error response error members as JSON objects before parsing
  • Reject missing or invalid error code / message fields with FormatException instead of Dart cast errors
  • Add edge-case coverage plus a CLI conformance fixture for malformed error objects

Validation

  • dart format .
  • dart analyze
  • git diff --check
  • dart test test/types_edge_cases_test.dart
  • (cd packages/mcp_dart_cli && dart test test/src/conformance_command_test.dart && dart run mcp_dart_cli:mcp_dart conformance --suite all --json)
  • dart test

Draft stacked PR for RC spec work. Do not merge/release to main until the spec is finalized.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.43%. Comparing base (e7cdefd) to head (21bce6f).

Additional details and impacted files
@@                          Coverage Diff                          @@
##           spec/json-rpc-method-wire-validation     #240   +/-   ##
=====================================================================
  Coverage                                 88.43%   88.43%           
=====================================================================
  Files                                        47       47           
  Lines                                      9319     9324    +5     
=====================================================================
+ Hits                                       8241     8246    +5     
  Misses                                     1078     1078           
Flag Coverage Δ
unittests 88.43% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@leehack
Copy link
Copy Markdown
Owner Author

leehack commented Jun 1, 2026

Closing this draft micro PR because the RC spec work has been consolidated into a smaller reviewable stack. This change is preserved in #270 (JSON-RPC metadata hardening); the consolidated tip is tree-identical to the previous micro-stack tip.

@leehack leehack closed this Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant