Skip to content

Validate JSON-RPC error data values#237

Closed
leehack wants to merge 1 commit into
spec/elicitation-content-numbersfrom
spec/json-rpc-error-data-json-values
Closed

Validate JSON-RPC error data values#237
leehack wants to merge 1 commit into
spec/elicitation-content-numbersfrom
spec/json-rpc-error-data-json-values

Conversation

@leehack
Copy link
Copy Markdown
Owner

@leehack leehack commented Jun 1, 2026

Summary

  • validate JSON-RPC error data as a JSON value when parsing and serializing
  • reject non-JSON Dart objects and non-finite numbers before transport encoding
  • add edge-case coverage for valid nested data and invalid data values

Validation

  • dart format .
  • dart analyze
  • git diff --check
  • dart test
  • cd packages/mcp_dart_cli && dart test test/src/conformance_command_test.dart
  • cd packages/mcp_dart_cli && dart run mcp_dart_cli:mcp_dart conformance --suite all --json

Draft stacked PR for the MCP 2026-07-28 RC work. Base is the prior stack branch, not main.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.43%. Comparing base (2b5e414) to head (f5d80ae).

Additional details and impacted files
@@                        Coverage Diff                        @@
##           spec/elicitation-content-numbers     #237   +/-   ##
=================================================================
  Coverage                             88.43%   88.43%           
=================================================================
  Files                                    47       47           
  Lines                                  9313     9314    +1     
=================================================================
+ Hits                                   8236     8237    +1     
  Misses                                 1077     1077           
Flag Coverage Δ
unittests 88.43% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@leehack
Copy link
Copy Markdown
Owner Author

leehack commented Jun 1, 2026

Closing this draft micro PR because the RC spec work has been consolidated into a smaller reviewable stack. This change is preserved in #270 (JSON-RPC metadata hardening); the consolidated tip is tree-identical to the previous micro-stack tip.

@leehack leehack closed this Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant