Skip to content

Require enum for elicitation enum names#215

Closed
leehack wants to merge 1 commit into
spec/elicit-result-integer-contentfrom
spec/elicitation-enum-names-validation
Closed

Require enum for elicitation enum names#215
leehack wants to merge 1 commit into
spec/elicit-result-integer-contentfrom
spec/elicitation-enum-names-validation

Conversation

@leehack
Copy link
Copy Markdown
Owner

@leehack leehack commented Jun 1, 2026

Summary

  • reject form elicitation schemas that include legacy enumNames without enum
  • cover both JSON parsing and typed serialization paths
  • document the stable and MCP 2026 schema alignment in the changelog

Tests

  • dart format lib/src/types/elicitation.dart test/elicitation_test.dart
  • dart test test/elicitation_test.dart test/mcp_2025_11_25_test.dart test/mcp_2026_07_28_test.dart
  • dart analyze
  • dart format .
  • git diff --check
  • dart test

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.03%. Comparing base (b7543b0) to head (2b82169).

Additional details and impacted files
@@                         Coverage Diff                         @@
##           spec/elicit-result-integer-content     #215   +/-   ##
===================================================================
  Coverage                               88.03%   88.03%           
===================================================================
  Files                                      47       47           
  Lines                                    9077     9078    +1     
===================================================================
+ Hits                                     7991     7992    +1     
  Misses                                   1086     1086           
Flag Coverage Δ
unittests 88.03% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@leehack
Copy link
Copy Markdown
Owner Author

leehack commented Jun 1, 2026

Closing this draft micro PR because the RC spec work has been consolidated into a smaller reviewable stack. This change is preserved in #269 (MCP 2026 result semantics); the consolidated tip is tree-identical to the previous micro-stack tip.

@leehack leehack closed this Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant