Skip to content

Reject non-integer elicitation content#214

Closed
leehack wants to merge 1 commit into
spec/2026-input-response-validationfrom
spec/elicit-result-integer-content
Closed

Reject non-integer elicitation content#214
leehack wants to merge 1 commit into
spec/2026-input-response-validationfrom
spec/elicit-result-integer-content

Conversation

@leehack
Copy link
Copy Markdown
Owner

@leehack leehack commented Jun 1, 2026

Summary

  • tighten ElicitResult.content validation to reject non-integer numeric values
  • cover both parse and serialization paths with regression tests
  • document the stable and MCP 2026 schema alignment in the changelog

Tests

  • dart format .
  • dart analyze
  • dart test test/elicitation_test.dart test/mcp_2025_11_25_test.dart test/mcp_2026_07_28_test.dart
  • git diff --check
  • dart test

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.03%. Comparing base (c955a2d) to head (b7543b0).

Additional details and impacted files
@@                         Coverage Diff                          @@
##           spec/2026-input-response-validation     #214   +/-   ##
====================================================================
  Coverage                                88.03%   88.03%           
====================================================================
  Files                                       47       47           
  Lines                                     9077     9077           
====================================================================
  Hits                                      7991     7991           
  Misses                                    1086     1086           
Flag Coverage Δ
unittests 88.03% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@leehack
Copy link
Copy Markdown
Owner Author

leehack commented Jun 1, 2026

Closing this draft micro PR because the RC spec work has been consolidated into a smaller reviewable stack. This change is preserved in #269 (MCP 2026 result semantics); the consolidated tip is tree-identical to the previous micro-stack tip.

@leehack leehack closed this Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant