Skip to content

Enforce subscription notification filters#205

Closed
leehack wants to merge 1 commit into
spec/2026-client-stateless-server-request-rejectionfrom
spec/2026-subscription-notification-filtering
Closed

Enforce subscription notification filters#205
leehack wants to merge 1 commit into
spec/2026-client-stateless-server-request-rejectionfrom
spec/2026-subscription-notification-filtering

Conversation

@leehack
Copy link
Copy Markdown
Owner

@leehack leehack commented May 31, 2026

Summary

  • enforce subscriptions/listen acknowledgment-before-events ordering in request-handler notification paths
  • reject subscription notifications outside the acknowledged filter, including resource URI and task id filters
  • tag direct extra.sendNotification(...) events on subscription streams with io.modelcontextprotocol/subscriptionId

Validation

  • dart format .
  • dart analyze
  • dart test test/types/subscriptions_test.dart test/mcp_2026_07_28_test.dart test/server/streamable_mcp_server_test.dart
  • dart test
  • dart pub global run coverage:test_with_coverage
  • dart run bin/mcp_dart.dart conformance --suite all --json (from packages/mcp_dart_cli)
  • git diff --check

Notes

@codecov
Copy link
Copy Markdown

codecov Bot commented May 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.62%. Comparing base (52ebbe2) to head (09a98d0).

Additional details and impacted files
@@                                   Coverage Diff                                   @@
##           spec/2026-client-stateless-server-request-rejection     #205      +/-   ##
=======================================================================================
+ Coverage                                                87.54%   87.62%   +0.08%     
=======================================================================================
  Files                                                       47       47              
  Lines                                                     8757     8803      +46     
=======================================================================================
+ Hits                                                      7666     7714      +48     
+ Misses                                                    1091     1089       -2     
Flag Coverage Δ
unittests 87.62% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@leehack leehack force-pushed the spec/2026-subscription-notification-filtering branch from 5fee6a0 to 09a98d0 Compare May 31, 2026 22:38
@leehack
Copy link
Copy Markdown
Owner Author

leehack commented Jun 1, 2026

Closing this draft micro PR because the RC spec work has been consolidated into a smaller reviewable stack. This change is preserved in #268 (MCP 2026 transport enforcement); the consolidated tip is tree-identical to the previous micro-stack tip.

@leehack leehack closed this Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant