Make cloud instance sizes configurable#106
Conversation
7080ff1 to
acdaf5b
Compare
|
@madebygps can you please review this ? |
|
Hi @SahilGupta2810 and maintainers, I just finished my first PR (#92). I'm familiar with Azure only. I'd like to help improve the Azure part of this PR:
Is that okay? I will only touch Azure files. |
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #95 by making the default VM/instance size configurable for AWS, Azure, and GCP Terraform deployments (while keeping existing defaults), and adds troubleshooting / command-flow documentation to help users handle common provider/account constraints.
Changes:
- Add new Terraform variables for compute sizing (
aws_instance_type,azure_vm_size,gcp_machine_type) and wire them into the corresponding instance/VM resources. - Add root troubleshooting guidance (currently AWS-focused) plus provider-specific “copy/paste” command guides.
- Update provider READMEs to link to the new docs.
Show a summary per file
| File | Description |
|---|---|
aws/main.tf |
Adds aws_instance_type variable and uses it for the EC2 instance. |
azure/main.tf |
Adds azure_vm_size variable and uses it for the VM size. |
gcp/main.tf |
Adds gcp_machine_type variable and uses it for the compute instance machine type. |
aws/README.md |
Updates AWS getting-started flow and links to command/troubleshooting docs. |
azure/README.md |
Links to the Azure command flow doc and troubleshooting doc. |
gcp/README.md |
Links to the GCP command flow doc and troubleshooting doc. |
TROUBLESHOOTING.md |
Adds beginner-facing troubleshooting guidance (AWS sections + placeholders for Azure/GCP). |
docs/AWS_COMMANDS.md |
Adds a guided command flow for selecting region/instance type and running Terraform. |
docs/AZURE_COMMANDS.md |
Adds a guided command flow for selecting subscription/region/VM size and running Terraform. |
docs/GCP_COMMANDS.md |
Adds a guided command flow for selecting project/region/zone/machine type and running Terraform. |
Copilot's findings
- Files reviewed: 10/10 changed files
- Comments generated: 2
| Or pass the exported value directly to Terraform: | ||
|
|
||
| ```sh | ||
| terraform apply -var="aws_region=$AWS_REGION" | ||
| ``` |
| <!-- Placeholder for future screenshots:  --> | ||
|
|
||
| Before your first AWS deploy, list the regions that are enabled for your account: |
|
Addressed the latest review feedback in . Changes made:
The directory has no Terraform configuration files. You may begin working
If there are any other adjustments needed, I can update the branch. |
|
@madebygps review changes are commited Addressed the latest review feedback in commit 5312ec3. Changes made:
If there are any other adjustments needed, I can update the branch. |
5312ec3 to
01fd1ac
Compare
| ```sh | ||
| terraform init | ||
| terraform apply | ||
| terraform apply -var="aws_region=$AWS_REGION" | ||
| ``` |
Summary
This PR addresses issue #95 by making the default compute size configurable across all three cloud providers, while preserving the current default behavior.
Changes
aws_instance_typevariable with defaultt3.microvar.aws_instance_typeazure_vm_sizevariable with defaultStandard_B1svar.azure_vm_sizegcp_machine_typevariable with defaulte2-microvar.gcp_machine_typeDocumentation
TROUBLESHOOTING.mdwith beginner-friendly AWS guidance for:docs/AWS_COMMANDS.mddocs/AZURE_COMMANDS.mddocs/GCP_COMMANDS.mdaws_regionbefore applying TerraformWhy
Issue #95 points out that fixed defaults for region and VM size can fail depending on account restrictions, quota, or provider availability. This change keeps the existing defaults intact while allowing users to override them without editing Terraform files directly.
Examples: