update how linebreaks are saved so they render properly in perseus#5904
Merged
Merged
Conversation
rtibbles
reviewed
May 26, 2026
Member
rtibbles
left a comment
rtibbles
left a comment
There was a problem hiding this comment.
Just one question about the mocking in the tests.
| }), | ||
| }; | ||
| }); | ||
| // Mock the whole module to avoid pulling in the ESM `marked` library in Jest. |
Member
There was a problem hiding this comment.
I am a little confused here - what exactly are we testing if our markdown util is entirely mocked in this test?
Member
Author
There was a problem hiding this comment.
agreed -- this is not necessary and is LLM generated that I didn't evaluate properly. I've reverted to what it was before, and tests still pass
marcellamaki
force-pushed
the
fix-linebreaks
branch
from
4bc06fa to
677d49a
Compare
marcellamaki
force-pushed
the
fix-linebreaks
branch
from
677d49a to
6cba2b2
Compare
rtibbles
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the second part of: #5894
(This was not a regression, thus we will put in our first patch release)
References
Fixes #5894
Reviewer guidance
AI usage
I used claude to both identify the cause of the issue and implement the solution here