Skip to content

Prevent untracked files complicating worktree removal#14743

Merged
rtibbles merged 2 commits into
learningequality:developfrom
bjester:misc-maint
May 28, 2026
Merged

Prevent untracked files complicating worktree removal#14743
rtibbles merged 2 commits into
learningequality:developfrom
bjester:misc-maint

Conversation

@bjester
Copy link
Copy Markdown
Member

@bjester bjester commented May 21, 2026

Summary

  • Adds more .gitignore rules for various AI harnesses that sometimes create local project files
  • Prevents test_enumerate_channel.py from creating untracked file file:memorydb_default in project root

Reviewer guidance

Tests pass?

AI usage

I had AI investigate the untracked file. Based off the name, it seems the intent was to have that be in-memory. AI found that file:memorydb_default?mode=memory&cache=shared was generated as a DB path and eventually went through the content plugin's sqlite handling code, and got formatted to sqlite:///file:memorydb_default?mode=memory&cache=shared. AI determined the missing uri=true was problematic.

@github-actions github-actions Bot added DEV: backend Python, databases, networking, filesystem... SIZE: small labels May 21, 2026
Copy link
Copy Markdown
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as tests pass, this seems fine to me.

Comment thread .gitignore
.codex*
.qwen/
.vibe/
.aider.config.yml
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost feels like we should just have an explicit allow list of .* files and folders, rather than excluding things (don't need to do that here).

@rtibbles
Copy link
Copy Markdown
Member

The test failure is not caused here, and has since been resolved on develop. Merging.

@rtibbles rtibbles merged commit 5a1bec8 into learningequality:develop May 28, 2026
80 of 82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DEV: backend Python, databases, networking, filesystem... SIZE: small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants