Prevent untracked files complicating worktree removal#14743
Merged
Conversation
rtibbles
approved these changes
May 21, 2026
Member
rtibbles
left a comment
There was a problem hiding this comment.
As long as tests pass, this seems fine to me.
| .codex* | ||
| .qwen/ | ||
| .vibe/ | ||
| .aider.config.yml |
Member
There was a problem hiding this comment.
Almost feels like we should just have an explicit allow list of .* files and folders, rather than excluding things (don't need to do that here).
Contributor
Build Artifacts
Smoke test screenshot |
Member
|
The test failure is not caused here, and has since been resolved on develop. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.gitignorerules for various AI harnesses that sometimes create local project filestest_enumerate_channel.pyfrom creating untracked filefile:memorydb_defaultin project rootReviewer guidance
Tests pass?
AI usage
I had AI investigate the untracked file. Based off the name, it seems the intent was to have that be in-memory. AI found that
file:memorydb_default?mode=memory&cache=sharedwas generated as a DB path and eventually went through the content plugin's sqlite handling code, and got formatted tosqlite:///file:memorydb_default?mode=memory&cache=shared. AI determined the missinguri=truewas problematic.