Repository navigation
fix(pana-score): avoid Dart SDK install collision - #65
Merged
Merged
Conversation
dart-lang/setup-dart downloads to a fixed filename under $RUNNER_TEMP without cleaning it up, so invoking this action more than once in the same job (e.g. scoring several packages) makes the second Dart install collide with the first's leftover zip and fail. Skip re-running setup once Dart is ready in the job, and defensively clear any stale download beforehand.
Query dart-archive's latest/VERSION and compare against `dart --version` on PATH; only (re)run dart-lang/setup-dart when the installed SDK isn't already the latest stable release, clearing any stale zip first so a reinstall can't collide with its own leftovers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dart-lang/setup-dartdownloads to a fixed filename under$RUNNER_TEMPwithout cleaning it up, so calling thepana-scoreaction more than once in the same job (e.g. scoring several packages, which the README already documents as a supported use case) makes the second install collide with the first's leftover zip and fail withDestination file path ... already exists.latest/VERSIONand compares it againstdart --versionalready onPATH;dart-lang/setup-dartis now only run when the installed SDK isn't already the latest stable release.dartsdk-*.zipin$RUNNER_TEMPis removed so the download can't collide with itself either.Test plan
pana-scoremore than once in the same job and confirm the second call skips the Dart install instead of failing.Generated by Claude Code