Repository navigation
fix(pana-score): give every scored package its own commit status - #64
Merged
Merged
Conversation
Package-name resolution ran partway through the score step, guarded by set -e, so a crash before that point (or the whole step being skipped after an earlier failure) left package-name unset. The status step then fell back to the bare "pana" context, which every such failure collided on again. Resolve the name first thing in the score step, shielded from set -e, with an "unknown" last resort. The status step now also resolves it independently as a fallback, in case the score step never ran at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pana-scoreaction once per package in a single PR reported every package under the same hardcodedpanacommit status context, so each run overwrote the previous one. The context is nowpana (<package-name>), giving each package its own status entry.package-nameoutput (resolved from the package'spubspec.yaml, falling back to its directory name).scorestep, shielded fromset -e, with anunknownlast resort — a crash later in the step (or the step being skipped entirely after an earlier failure) no longer leaves the status context to fall back to the bare, collision-pronepana. The status-reporting step also resolves the name independently as a further fallback.scoreoutput/description text and step-summary header, since the commit status context and description already carry it separately.Test plan
pana (<package-name>)commit status instead of overwriting a shared one.score/state/package-nameoutputs still render correctly for both successful and failingpanaruns.Generated by Claude Code