Repository navigation
test(rx-pipe-client): add unit tests - #293
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DXXPnGepYUGie3we1X9PTR
claude
Bot
requested review from
BeerHobbyist,
Komoszek,
alszczep,
kamilgacan,
katarzynagrasewicz,
konowrockis and
kumalg
as code owners
June 25, 2026 09:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Sebastian Konowrocki · Slack thread
Before / After
@leancodepl/rx-pipe-clientpreviously had no tests. It now has 12 unit tests coveringmkPipeClientand itscreateTopicfactory: lazy factory creation (no prematurepipe.topiccall), correct forwarding of topic type and the exact topic-argument reference, observable passthrough, multi-notification streaming, live emission via aSubject, error propagation, unsubscription/teardown, per-invocation call counting, isolation between distinct topic types, empty-argument handling, and per-instance pipe binding.How
A mocked
Pipe(vi.fnfortopic) returns RxJS observables (of/Subject/throwError/ customObservable) so the wrapper's currying and argument forwarding are asserted against real subscription behavior.rxjsis added as a devDependency since it is used only by the tests.🤖 Generated with Claude Code
https://claude.ai/code/session_01DXXPnGepYUGie3we1X9PTR
Generated by Claude Code