Repository navigation
test(antd-table-hooks): add unit tests - #289
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DXXPnGepYUGie3we1X9PTR
claude
Bot
requested review from
BeerHobbyist,
Komoszek,
alszczep,
kamilgacan,
katarzynagrasewicz,
konowrockis and
kumalg
as code owners
June 25, 2026 09:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Sebastian Konowrocki · Slack thread
Before / After
@leancodepl/antd-table-hookspreviously had no tests. This PR adds 49 unit tests (5 spec files) covering the package's full public API:usePagination— standalone and URL/query-state modes, zero-indexedpageoutput, default page size (100),getTablePaginationconfig (total passthrough, size options,onChange),resetPage, and callback wiring.useSorting— standalone and query-state modes,isDescendingderivation,sortData.onChangeupdates, clearing sort onundefined,onSortUpdatecallback, and resync on prop change.useFilters—applyFilterscomposition across multiple active filters,anyFilterSet, clearing a filter,onFiltersChangepayload,reset$propagation viaresetFilters, and seeding frominitialValues.defineFilters— static array and context-factory forms, combined Zod search-schema building, and handling of schema-less filters.useTable— default/derived state from query params,onPaginationChange/onSortUpdate/onFiltersChangewriters (default-value omission, param preservation, empty-value stripping, page reset on filter change), plus thebuildPaginationSearchSchema,buildSortingSearchSchema, andtableSearchSchemabuilders.How
Tests use
@testing-library/react(renderHook/render/act) mirroring the conventions of sibling packages, run under the package's existing vitest/jsdom config. Edge cases covered: empty/null/undefined values, default-vs-non-default boundaries, multi-filter composition, and reset/cancellation flows.🤖 Generated with Claude Code
https://claude.ai/code/session_01DXXPnGepYUGie3we1X9PTR
Generated by Claude Code