Repository navigation
test(image-uploader): add unit tests - #288
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DXXPnGepYUGie3we1X9PTR
claude
Bot
requested review from
BeerHobbyist,
Komoszek,
alszczep,
kamilgacan,
katarzynagrasewicz,
konowrockis and
kumalg
as code owners
June 25, 2026 09:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Sebastian Konowrocki · Slack thread
Before / After
The
@leancodepl/image-uploaderpackage previously had no tests. This PR adds 47 unit tests (6 spec files) covering the package's real runtime logic:mapFileRejectionsToErrorCode/ErrorCode— code mapping, priority ordering (FileTooLarge > FileTooSmall > FileInvalidType > TooManyFiles), empty/unknown rejections, multi-rejection flattening.isExactFile— name/size/lastModified equality across matching and differing inputs.getImagePreviewData— base64 data URL output, MIME-type prefix preservation, empty input, and FileReader error rejection.tryUploadWithUploadParams— already-uploaded short-circuit, missing file, successful fetch upload, and the error paths (null params, non-ok response, fetch rejection, getUploadParams rejection).useUploadImages— accept defaulting/pass-through, add/dedup/remove/clear file flows, drop handling with generated ids, rejection-to-error mapping, optional-callback safety, and cropper config exposure.useCropper— queue/open state, FileReader-driven editorImage loading, close-and-advance vs close-and-empty, acceptImage append behavior, and crop/zoom/rotation setters.How
Vitest + jsdom following sibling-package conventions (
@testing-library/reactrenderHook/act,vi.mockforreact-dropzone/uuid);fetchandFileReaderare stubbed where needed. Added@testing-library/react,react, andvitestto the package's devDependencies to satisfy the import lint rule.🤖 Generated with Claude Code
https://claude.ai/code/session_01DXXPnGepYUGie3we1X9PTR
Generated by Claude Code