Repository navigation
ci: pin GitHub Actions to commit SHA - #281
Merged
Merged
Conversation
Contributor
|
Also pin actions in the other flow |
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DXXPnGepYUGie3we1X9PTR
Author
|
Done — pinned the actions in
These are the same SHAs used in |
konowrockis
marked this pull request as ready for review
June 24, 2026 10:53
konowrockis
requested review from
BeerHobbyist,
Komoszek,
alszczep,
kamilgacan,
katarzynagrasewicz,
konowrockis and
kumalg
as code owners
June 24, 2026 10:53
konowrockis
approved these changes
Jun 24, 2026
Komoszek
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Sebastian Konowrocki · Slack thread
Before:
.github/workflows/ci.yamlreferencedactions/checkout@v3andactions/setup-node@v3by floating major-version tag. Tag refs are mutable: whoever controls the upstream repo (or an attacker who compromises it, as in the recent "shai-hulud" style supply-chain worms) can move a tag to point at malicious code, which CI would then execute with repository credentials.After: Both actions are pinned to the immutable full commit SHA of their current v5 release, with a trailing comment naming the version so the intent stays readable:
actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0Following review feedback, the same SHA pinning is now also applied to
release.yaml, which previously pinned these actions by the floating@v5tag:actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5A SHA cannot be repointed, so the exact action code that runs is fixed and auditable.
How: Edits the
uses:lines in.github/workflows/ci.yamland.github/workflows/release.yaml. SHAs were resolved from the upstreamactions/checkoutandactions/setup-noderepositories (the commit each v5 tag points to — verified that@v5resolves to the same tree asv5.0.1/v5.0.0respectively).Generated by Claude Code