Skip to content

iOS Done Color Dark Mode #694

Description

@DevinFrenze

Describe the bug

The react-native-picker-select "Done" text on iOS in dark mode is white. However, the "Done" text on iOS in dark mode for other native components, such as the keyboard, is blue. I believe the correct color value for this text is #0a84ff

Also, the blue color that is used for the "Done" text in light mode is a hard-coded color variable when it could be a reference to a PlatformColor.

To Reproduce

Steps to reproduce the behavior:

  1. Render a react-native-picker-select with the darkTheme property set to true
  2. Observe that the text is white

Expected behavior

The text should be system blue, matching the "Done" text of other iOS native components. I believe the value is described here.

Screenshots

Light mode uses system blue for "Done" text color:

Image

Dark mode does not use system blue for "Done" text color:

Image

Additional details

  • Device: iPhone (any)
  • OS: iOS (any)
  • react-native-picker-select version: 9.3.1
  • react-native version: (any)
  • expo sdk version: (any)

Reproduction and/or code sample

Link to Expo Snack. I couldn't get the iOS picker to open in Expo Snack but this is the correct code to reproduce the issue.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions