Merged
Conversation
sarroutbi
force-pushed
the
202503131146-fix-readme-md
branch
from
4a453ec to
b23ef33
Compare
Collaborator
sergio-correia
left a comment
sergio-correia
left a comment
There was a problem hiding this comment.
Looks good, but I would avoid the -y. Not a great practice to do these things without confirmation. While most people would do it sometimes, I would not recommend it in the README.
Signed-off-by: Sergio Arroutbi <sarroutb@redhat.com>
sarroutbi
force-pushed
the
202503131146-fix-readme-md
branch
from
b23ef33 to
eec87be
Compare
sergio-correia
approved these changes
Mar 13, 2025
Collaborator
Author
|
Thanks for the quick review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.