Skip to content

docs(skills): verify current date for relative dates#1754

Open
godququ5-code wants to merge 2 commits into
larksuite:mainfrom
godququ5-code:fix-1752-current-date
Open

docs(skills): verify current date for relative dates#1754
godququ5-code wants to merge 2 commits into
larksuite:mainfrom
godququ5-code:fix-1752-current-date

Conversation

@godququ5-code

@godququ5-code godququ5-code commented Jul 5, 2026

Copy link
Copy Markdown

Summary

Add shared current-date anchoring guidance and explicitly wire it into the date-sensitive Lark skills that interpret relative dates. This prevents stale defaults such as assuming 2025 from examples, history, or model memory.

Changes

  • Add a 日期锚点与相对日期 section to lark-shared as the shared source of truth for current-date/current-year handling.
  • Reference that shared rule from date-sensitive skills:
    • lark-calendar
    • lark-task
    • lark-workflow-standup-report
    • lark-workflow-meeting-summary
  • Clarify that examples only demonstrate format and must not be used to infer the current year.

Test Plan

  • Unit tests pass (not run; docs/skill-only change)
  • Manual local verification confirms the lark-cli <domain> <command> flow works as expected (not applicable; no CLI behavior changed)

Validation run:

  • node scripts/skill-format-check/index.js
    • validates the updated domain skill files; note that this script explicitly skips lark-shared
  • custom node check for skills/lark-shared/SKILL.md
    • verifies frontmatter exists, the description includes current-date anchoring, the shared date section exists, and the 2025 guard remains present
  • git diff --check

Related Issues

Summary by CodeRabbit

  • Documentation
    • 新增并统一“日期锚点与相对日期”说明:处理“今天/明天/本周/上周/今年/当前年份”等相对日期时,以运行环境或系统消息中的当前日期与时区为锚点。
    • 缺少可靠锚点时,先获取本机日期;日期加减、周边界与时间戳转换以系统命令或脚本计算,避免心算。
    • 明确不再从示例、历史对话或旧资料推断年份,且不默认使用 2025。
    • 会议纪要与站会报告的流程补充了显式的目标日期步骤,按同一规则先解析再生成时间范围。

@CLAassistant

CLAassistant commented Jul 5, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions Bot added the size/M Single-domain feat or fix with limited business impact label Jul 5, 2026
@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Updates shared date-anchor guidance and propagates it to calendar, task, and workflow skill instructions so relative dates are resolved from the real current date and timezone before absolute times are produced.

Changes

Date anchoring documentation

Layer / File(s) Summary
Shared relative-date rule
skills/lark-shared/SKILL.md
Adds rules for anchoring relative dates to the current runtime or system-message date and timezone, using date when needed, computing date arithmetic with commands or scripts, and avoiding year inference from examples, history, training data, or old docs.
Calendar and task date resolution
skills/lark-calendar/SKILL.md, skills/lark-task/SKILL.md
Adds calendar and task instructions that require resolving relative date anchors through lark-shared before converting them into absolute query, API, or filter values.
Workflow date-range steps
skills/lark-workflow-meeting-summary/SKILL.md, skills/lark-workflow-standup-report/SKILL.md
Updates workflow steps to determine the actual current date and timezone first, then derive absolute date ranges; the meeting-summary reference list also adds the lark-doc bullet.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested labels: documentation

Suggested reviewers: albertnusouo, calendar-assistant

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The PR addresses #1752 by adding shared current-date anchoring and wiring it into the date-sensitive skills.
Out of Scope Changes check ✅ Passed The changes stay focused on date-anchoring guidance across related skill docs, with no obvious unrelated additions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title is concise and clearly describes the main change: verifying current date handling for relative dates.
Description check ✅ Passed The description matches the required template and includes summary, changes, test plan, and related issues with meaningful details.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sang-neo03

Copy link
Copy Markdown
Collaborator

@godququ5-code
Thanks for the PR. I do not think we should merge this as-is.

The direction is reasonable, but the fix is too narrow. The issue is about relative date and current-year handling across date-sensitive skills, not only shared authentication guidance.
Adding the rule only to lark-shared does not fully cover the places where relative dates are actually interpreted, such as calendar, task, standup report, and meeting summary flows.

There are already domain-specific time rules in the repository, for example in lark-calendar and lark-workflow-meeting-summary. This PR adds another generic rule without
consolidating those existing rules or updating the affected domain skills, so it may make the issue look fixed while leaving the main behavior inconsistent.

Also, the validation note mentions node scripts/skill-format-check/index.js, but that script explicitly skips lark-shared, so it does not validate the changed file.

I would prefer not to merge this PR. A better fix should update the date-sensitive skills or introduce a clearly scoped shared time/date rule that those skills explicitly reference.

@godququ5-code
godququ5-code force-pushed the fix-1752-current-date branch from 251229a to 28e5b02 Compare July 8, 2026 15:58
@godququ5-code
godququ5-code force-pushed the fix-1752-current-date branch from 28e5b02 to 63292dc Compare July 8, 2026 15:58
@github-actions github-actions Bot added domain/calendar PR touches the calendar domain domain/task PR touches the task domain size/L Large or sensitive change across domains or core paths and removed size/M Single-domain feat or fix with limited business impact labels Jul 8, 2026
@godququ5-code

Copy link
Copy Markdown
Author

Addressed the scope issue in the latest push.

Changes made:

  • kept lark-shared as the shared source of truth for current-date/current-year anchoring;
  • explicitly referenced that shared rule from the date-sensitive skills where relative dates are interpreted: lark-calendar, lark-task, lark-workflow-standup-report, and lark-workflow-meeting-summary;
  • updated the PR validation notes to state that node scripts/skill-format-check/index.js validates the domain skill files but skips lark-shared, and added a separate local check for the lark-shared date guidance.

This keeps the shared rule scoped while making the affected domain flows opt into it explicitly, so the issue should no longer appear fixed only at the generic shared-auth layer.

@godququ5-code

Copy link
Copy Markdown
Author

Hi @sang-neo03, just following up on the July 8 revision. I updated the date-sensitive skills to reference the shared date rule explicitly and corrected the validation notes. Could you let me know whether this addresses the scope concern, or if further consolidation is preferred?

@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown

PR Quality Summary

CI did not complete successfully. Use the failed check links below to decide whether this PR needs a code change or a rerun.

Failed checks

@github-actions

Copy link
Copy Markdown

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@63292dc34e3b4e131a76e454c41b553ac6fde39e

🧩 Skill update

npx skills add godququ5-code/cli#fix-1752-current-date -y -g

@godququ5-code

Copy link
Copy Markdown
Author

@sang-neo03 Thanks for the detailed feedback. I've expanded the scope in the latest push to address the points you raised:

  • lark-shared/SKILL.md remains the single shared source of truth for current-date / current-year anchoring.
  • The date-sensitive domain skills now explicitly reference that shared rule instead of relying on a separate generic one:
    • skills/lark-calendar/SKILL.md
    • skills/lark-task/SKILL.md
    • skills/lark-workflow-meeting-summary/SKILL.md
    • skills/lark-workflow-standup-report/SKILL.md

This consolidates the existing domain-specific time rules under the shared anchor rather than adding a parallel one. Could you please take another look when you have a chance? Happy to adjust further if anything is still off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain/calendar PR touches the calendar domain domain/task PR touches the task domain size/L Large or sensitive change across domains or core paths

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The agent defaults to taking 2025 as the current year

3 participants