docs(skills): verify current date for relative dates#1754
docs(skills): verify current date for relative dates#1754godququ5-code wants to merge 2 commits into
Conversation
📝 WalkthroughWalkthroughUpdates shared date-anchor guidance and propagates it to calendar, task, and workflow skill instructions so relative dates are resolved from the real current date and timezone before absolute times are produced. ChangesDate anchoring documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@godququ5-code The direction is reasonable, but the fix is too narrow. The issue is about relative date and current-year handling across date-sensitive skills, not only shared authentication guidance. There are already domain-specific time rules in the repository, for example in Also, the validation note mentions I would prefer not to merge this PR. A better fix should update the date-sensitive skills or introduce a clearly scoped shared time/date rule that those skills explicitly reference. |
251229a to
28e5b02
Compare
28e5b02 to
63292dc
Compare
|
Addressed the scope issue in the latest push. Changes made:
This keeps the shared rule scoped while making the affected domain flows opt into it explicitly, so the issue should no longer appear fixed only at the generic shared-auth layer. |
|
Hi @sang-neo03, just following up on the July 8 revision. I updated the date-sensitive skills to reference the shared date rule explicitly and corrected the validation notes. Could you let me know whether this addresses the scope concern, or if further consolidation is preferred? |
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@63292dc34e3b4e131a76e454c41b553ac6fde39e🧩 Skill updatenpx skills add godququ5-code/cli#fix-1752-current-date -y -g |
|
@sang-neo03 Thanks for the detailed feedback. I've expanded the scope in the latest push to address the points you raised:
This consolidates the existing domain-specific time rules under the shared anchor rather than adding a parallel one. Could you please take another look when you have a chance? Happy to adjust further if anything is still off. |
Summary
Add shared current-date anchoring guidance and explicitly wire it into the date-sensitive Lark skills that interpret relative dates. This prevents stale defaults such as assuming 2025 from examples, history, or model memory.
Changes
日期锚点与相对日期section tolark-sharedas the shared source of truth for current-date/current-year handling.lark-calendarlark-tasklark-workflow-standup-reportlark-workflow-meeting-summaryTest Plan
lark-cli <domain> <command>flow works as expected (not applicable; no CLI behavior changed)Validation run:
node scripts/skill-format-check/index.jslark-sharednodecheck forskills/lark-shared/SKILL.mdgit diff --checkRelated Issues
Summary by CodeRabbit