Conversation
When iterating through a dictionary, get a tuple of keys instead of a view, avoiding errors when the dictionary changes.
Archived EVCs cannot be used or changed, so there is no need for them to be in memory.
When an EVC cannot be loaded, a message is logged as error instead of info. Co-authored-by: Italo Valcy S Brito <italovalcy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description of the Change
This PR fixes same issues found when creating/editing several EVCs at once.
💻 Verification Process
Unit tests passed.
One of the tests was modified to reflect archived EVCs not being loaded.
📄 Release Notes
Examples: