No strict yoda style will return, he will#21
Merged
Merged
Conversation
Qodana for PHPIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
Collaborator
|
@tdashton please check this Teams thread and align with @hugo-goncalves-kununu, seems you're working on same thing? |
Collaborator
|
No problem with this PR, I am working on a new major release |
Contributor
Author
|
@hugo-goncalves-kununu @danielsantos-kununu ah thanks for the note! Then feel free to approve if this won't conflict with the major version update, or we can close otherwise! |
hugo-goncalves-kununu
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The migration from kununu-scripts to here seems to have not migrated the indifference to yoda rules, so I migrate it here with the description of the PR below:
We prefer to leave the behavior up to the projects, i.e. if yoda style leave it if not leave it too.
The documentation of php cs is officially
The configuration here is a more explicit version of
false.