Skip to content

KUNGBE-248 [BE] Add the php-cs-fixer to code-tools #13

Merged
jcostaventureoak merged 38 commits into
mainfrom
KUNGBE-248
Aug 21, 2025
Merged

KUNGBE-248 [BE] Add the php-cs-fixer to code-tools #13
jcostaventureoak merged 38 commits into
mainfrom
KUNGBE-248

Conversation

@jcostaventureoak

@jcostaventureoak jcostaventureoak commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

JIRA issue

KUNGBE-248

Description

The objective of this PR is to:

  • Add thePHP-CS-Fixer
  • Add the .editorconfig

@github-actions

github-actions Bot commented Jul 1, 2025

Copy link
Copy Markdown

Qodana for PHP

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@jcostaventureoak jcostaventureoak changed the title Add coding standards Add PHP-CS-Fixer Jul 1, 2025
@jcostaventureoak jcostaventureoak changed the title Add PHP-CS-Fixer KUNGBE-248 Add PHP-CS-Fixer Jul 1, 2025
zibellino
zibellino previously approved these changes Jul 17, 2025

@zibellino zibellino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@jcostaventureoak jcostaventureoak marked this pull request as ready for review July 25, 2025 10:54
@jcostaventureoak jcostaventureoak requested a review from a team as a code owner July 25, 2025 10:54
@jcostaventureoak jcostaventureoak changed the title KUNGBE-248 Add PHP-CS-Fixer KUNGBE-248 [BE] Add the php-cs-fixer to code-tools Aug 21, 2025
@jcostaventureoak jcostaventureoak merged commit 2fee654 into main Aug 21, 2025
4 checks passed
@jcostaventureoak jcostaventureoak deleted the KUNGBE-248 branch August 21, 2025 11:28
Comment on lines +75 to +77
'equal' => false,
'identical' => false,
'less_and_greater' => false,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been changed again in the meantime:
kununu/kununu-scripts#30

Suggested change
'equal' => false,
'identical' => false,
'less_and_greater' => false,
'equal' => null,
'identical' => null,
'less_and_greater' => null,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might worth explaining here the usage of ij_ and php_ prefixes in the .dist

Comment thread php-cs-fixer.php
Comment on lines +75 to +77
'equal' => false,
'identical' => false,
'less_and_greater' => false,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants