Repository navigation
Conversation
Owner
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 7, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrates codemem's MCP implementation to the split SDK v2 packages for 0.49. The stdio and HTTP entrypoints support both MCP 2026-07-28 discovery and legacy
initializeclients through the official SDK serving APIs.serveStdiowith legacy support and one store across discovery probes and fallback. Shutdown closes the protocol handle before draining the store.createMcpHandlerand the Node adapter for HTTP. OAuth router, provider, bearer middleware, and error classes stay together on the SDK's legacy auth compatibility surface. Issuer metadata does not claim support the separate OIDC callback cannot provide.-32602. Registered-tool validation and business errors still return tool execution errors. Local callers handle protocol errors explicitly.Protocol support does not enable safe cross-project pooling by itself. Caller-context integration remains separate.
Type of Change
Testing
pnpm run tsc,pnpm run lint,pnpm run test)Node 24.22.2: build, typecheck, Biome error checks, and delta ratchet pass. The completed migration passes 348 MCP tests, packaged CLI/plugin checks, and real OpenCode 2.2.6 acceptance with pooling off. Legacy mode negotiates 2025-11-25; modern and auto select 2026-07-28. Each discovers fourteen tools and successfully calls a tool again after an execution error.
Checklist
pnpm run lintpasses for touched files)Post-fork validation on current
main: standardpnpm run test:cipassed 33,609 tests, then 92 tests in its required serial run. Build, typecheck, and Biome checks pass under Node 24.22.2.Fresh post-fork OpenCode 2.2.6 acceptance passed under Node 24.22.2 using one isolated scratch database per protocol. Legacy negotiated 2025-11-25; modern and auto selected 2026-07-28. Each listed exactly fourteen tools and completed success, expected tool error, and recovery on the same connection (nine actual calls total). Pooling was disabled and no plugin was loaded.