Repository navigation
feat(plugin): add locked conditional recovery for retained events - #2591
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kunickiaj
force-pushed
the
feat/conditional-rejected-recovery
branch
from
November 7, 2026 17:33
17bd200 to
0e9452f
Compare
Owner
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add storage primitives for explicit recovery of retained rejected events. Recovery holds a per-event lock, passes the original serialized bytes to a delivery callback, and removes the retained copy only after a strict acknowledgement and an unchanged snapshot check.
Delivery, cleanup, and lock-release outcomes are reported separately so a release failure cannot hide a durable success or replace the original exception. The plugin reference documents lock repair and durability limits.
These primitives are not yet connected to HTTP retry or automatic queue advancement.
Type of Change
Testing
After restacking onto main:
pnpm run tsc, 147 tests across six recovery/delivery/inspection files, andpnpm lint:delta -- --base main --jsonpassed.Before restacking: full workspace build, packed-artifact smoke, and nine legacy spool tests passed.
Recovery tests cover competing processes, crashes, acknowledgement rejection, snapshot changes, and filesystem failures.
Relevant checks pass locally (
pnpm run tsc,pnpm run lint,pnpm run test)Added/updated tests for changes
Manually verified changes work as expected
Checklist
pnpm run lintpasses for touched files)