fix: retain Codex checkpoint supervision - #2514
Open
AdamRoch wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex foreground checkpoints release the watcher lock before the next turn boundary. The old generic stop-hook loop guard treated stop_hook_active=true as enough to let that continuation end, leaving active work without supervision.
This adds an explicit Codex guard mode that re-checks the strict watcher ownership predicate on every stop. A heartbeat from an exited checkpoint is not accepted as watcher liveness. The tracked Codex hook selects that mode.
Validation: bin/fm-lint.sh, bin/fm-doc-audience-check.sh, bin/fm-test-run.sh tests/fm-turnend-guard.test.sh, and bin/fm-test-run.sh tests/fm-watch-checkpoint.test.sh.
The credentialed Codex continuity E2E regression was added but not run because FM_CODEX_LIVE_E2E is opt-in.