Repository navigation
docs(catalog): pin plex-axi to v0.8.0 and admit in full - #230
Conversation
|
0eef10c to
792e9db
Compare
|
Speaking as Kun's firstmate: first-time fork workflows approved (docs-check and Guard generated files are green). Blocked on no-mistakes CI. The required check failed with "This PR was not raised through no-mistakes." The PR body has the HTML Please re-raise via |
|
Speaking as Kun's firstmate: independent source review of dmealing/plex-axi at pin Contract-class (catalog PR): opt-in. VISION per-rule (so far)
Still blocked: no-mistakes required check red (missing signed Pipeline section). Docs-check + Guard generated files green after fork approval. Will merge only after no-mistakes is green; no captain flag (author/CI wait). |
…reviewed_components
… reviewed_components
792e9db to
56ebf38
Compare
Resolve catalog/README/docs conflicts after kunchenguid#231 by retaining both exception admissions and regenerating catalog-community regions.
|
Speaking as Kun's firstmate: re-triage after newer activity (Pipeline section + Greptile). CI / conflict: Before merge, tip @dmealing please re-run Contract-class: opt-in. VISION (this fire)
No captain flag (author/CI wait on attestation re-bind). |
v0.8.0 (f31149d) closes the principle gaps recorded for the v0.6.1 pin: four-field list defaults, size-bounded api output, idempotent playlist writes, hook status/removal plus session-end capture, a home view that exits 0 without configuration, and recent follow-ups that keep --type. It also refuses state-changing GET paths in api and redacts credential attributes in api responses.
| status: admitted | ||
| reviewed_revision: f31149dfdc4e8424f43aa5e17c1252ff7c873a88 |
There was a problem hiding this comment.
Admission contradicts stated intent The PR’s Intent calls for plex-axi v0.6.1 to be listed as an exception with six partial principles. This entry instead marks v0.8.0 as admitted and omits those exceptions. Catalog readers therefore see a different version and verdict than the accepted Intent specifies, violating the repository directive to respect that Intent.
Context Used: If there is a VISION.md file at the root of the repo, the PR must not conflict / diverge / drift from it. If the PR description has an "Intent" section, respect that as the accepted user intent. - Do make comments if anything in the implementation ... (source)
|
@greptileai re-review — this review started while the PR description still carried the earlier v0.6.1 exception intent. The description was updated seconds later to the current intent (pin v0.8.0, admitted in full), which matches the catalog change. |
|
Speaking as Kun's firstmate: re-triage after the v0.8.0 re-pin, with an independent source review of dmealing/plex-axi at pin Contract-class (catalog PR): opt-in. It updates one community catalog entry and changes no axi default behavior. VISION per-rule
CI: no-mistakes, drift, Guard generated files, and Greptile are green on tip Squash-merged as |
|
Speaking as Kun's firstmate: this is merged. Thank you @dmealing — really appreciate you taking the time on this. |
Intent
Pin the plex-axi entry (https://github.com/dmealing/plex-axi) in the AXI community catalog to release v0.8.0, tag commit f31149dfdc4e8424f43aa5e17c1252ff7c873a88. plex-axi is structured, per-field music search and diagnosis over the Plex Media Server API, with writes and playback off unless explicitly enabled. v0.8.0 fixes two safety defects found by live testing against a real Plex server: the raw
apicommand could forward state-changing GET requests past the write and playback gates, andapi /myplex/accountprinted the account's plex.tv token unredacted. It also closes the partial AXI principles recorded for the earlier pin, so the entry is admitted in full rather than as an exception. The catalog entry and the generated README and docs regions are updated together, keeping the hass-axi entry already on main. The skill command isplex-axi skill.What Changed
catalog.yamlwith v0.8.0 (commit f31149dfdc4e8424f43aa5e17c1252ff7c873a88), fixing two safety defects: rawapicommand could forward state-changing GET requests past write/playback gates;api /myplex/accountprinted plex.tv token unredactedRisk Assessment
✅ Low: Catalog/docs-only change; new entry correctly drops the prior exception (admitted in full), pin matches intent's tag/commit exactly, safety-fix claims (api GET-only state-changing-path refusal, token redaction) are consistent with source_observations, and generated README/docs regions mirror the catalog entry with no hand-edits visible.
Testing
All 5 user-intent scenarios passed live: catalog entry pinned to v0.8.0 with full admission, reviewed_components complete, documentation regenerated and in sync, hass-axi entry preserved, security fixes documented. Regression test suite passed: 11 catalog rendering tests and 185 SDK tests all green. No blocking issues found.
Evidence: Test evidence
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
⏭️ **Rebase** - skipped
README.md- merge conflict rebasing onto origin/maincatalog.yaml- merge conflict rebasing onto origin/maindocs/index.html- merge conflict rebasing onto origin/main✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
grep -A 8 "name: plex-axi" catalog.yaml | grep reviewed_revisiongrep item.py in plex-axi reviewed_componentspnpm run docs:checkgrep "name: hass-axi" catalog.yamlgrep credential redaction and STATE_CHANGING_PATH in plex-axi observationspnpm run docs:test (11 tests)pnpm test in packages/axi-sdk-js (185 tests)grep plex-axi in README.mdgrep plex-axi in docs/index.htmlgit status verification✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.