docs(catalog): admit gerrit-axi at v0.4.0 - #222
Closed
slnkjthien wants to merge 1 commit into
Closed
slnkjthien wants to merge 1 commit into
slnkjthien wants to merge 1 commit into
Conversation
The v0.2.0 exception items were cleared in v0.3.0. The three gaps still open there are closed in v0.4.0: the bare dashboard now shows bin and description, status rows default to four fields with --fields for more, and submit on a merged change exits 0 with already_merged. No gap is left, so the entry moves to admitted.
|
Contributor
Author
|
Duplicate of #221, which already merged; opened by mistake. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
gerrit-axi was added to the axi community catalog in #215 with admission status
exception, reviewed at its v0.2.0 release (revision 047541439990d18c000858813fff0cebf7bd0dc4). The exception listed eight gaps against the AXI principles: errors on stderr, unknown-flag errors not listing valid flags, no live home view with no arguments, no help next-step hints, untruncated bodies, subcommand --help printing full usage, --version format and load cost, and no setup command or installable skill for session integration.gerrit-axi v0.4.0 (https://github.com/slnkjthien/gerrit-axi/releases/tag/v0.4.0) claims to close all of those, plus three more found in a v0.3.0 re-review: no bin and description on the bare home view, 17-field status rows with no --fields, and submit on an already-merged change exiting 5.
This updates the catalog entry to match: re-review the source at the v0.4.0 tag by someone who did not build those changes, refresh the description and the admission record, and move the entry from
exceptiontoadmittedif nothing remains.What Changed
gerrit-axientry incatalog.yamlfromexceptiontoadmitted. It was reviewed at revision7fb81b92e41f2a1f213b835c1337f4333f5a2c82(the v0.4.0 release). The old exception text is gone. The list of reviewed components now also coverssrc/axi/version.js,help.js,hints.js,setup.js,src/core/message.js,rest.js,ssh.js,skills/gerrit-axi/SKILL.md, andtest/axi.test.js.--versionand-v--helphelp[]hintsstatusrows cut to four fields by default, with--fieldsto add more--fullhintsetup hooksand the installable skill for session integrationmessagewritecatalog.yaml, in the generated catalog region ofREADME.md, and indocs/index.html.🤖 Generated with Claude Code
Risk Assessment
✅ Low: Only catalog metadata changed. The new reviewed_revision (7fb81b9) is the v0.4.0 tag commit, and every source observation checked against that tag holds. The description matches across catalog.yaml, README.md and docs/index.html, and moving the entry to admitted with the exception field dropped is what the intent asks for.
Testing
Installed the repo's dev dependencies and ran the docs generator check and its tests; both pass, so the README and docs/index.html regions match the new catalog entry. Cloned gerrit-axi at the v0.4.0 tag, confirmed the tag SHA equals reviewed_revision and every reviewed component exists, then drove the real CLI in an isolated HOME and a scratch git repo. That confirmed the bare version output, stdout-only typed errors with distinct exit codes, unknown-flag and unknown-field remedies that list the valid options, per-command help pages, the ambient home view with bin and description, and
setup hooksinstall, idempotent rerun and remove, where remove kept a foreign hook. The dashboard success path, body truncation and already-merged submit need a live Gerrit server. They were checked only through the upstream fake-runner suite, which passes, and I did not query the user's internal Gerrit because its data would end up in a public PR. No screenshot of the docs table: the change is a text-only cell in generated HTML, and no Chrome binary was available (chrome-devtools-axi opened no pages). I removed the node_modules I installed and the temp clone.--version,-v,-Vprint the bare0.4.0and exit 0status --bogusand--limtlist the valid flags and suggest --limit;--fields nopelists the valid fields; all exit 2status --helpandsetup --helpprint that command's page, not the full top-level usagesetup hooksinstalls Claude/Codex/OpenCode hooks, a rerun reports unchanged,--removetakes out only its own entries (a foreign hook survives), anddashboard --ambientprint…gerrit-axii…Evidence: gerrit-axi v0.4.0 CLI transcript (version, bare, flags, help, ambient)
Evidence: gerrit-axi v0.4.0 transcript with a resolved but unreachable host
Evidence: gerrit-axi setup hooks install/unchanged/remove transcript
Evidence: setup hooks --remove keeps a foreign hook
Evidence: gerrit-axi upstream axi/vote-ban tests at v0.4.0
Evidence: docs:check output
docs:check ok — generated regions match their sourcesEvidence: v0.4.0 tag SHA
7fb81b92e41f2a1f213b835c1337f4333f5a2c82 refs/tags/v0.4.0Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
--version,-v,-Vprint the bare0.4.0and exit 0status --bogusand--limtlist the valid flags and suggest --limit;--fields nopelists the valid fields; all exit 2status --helpandsetup --helpprint that command's page, not the full top-level usagesetup hooksinstalls Claude/Codex/OpenCode hooks, a rerun reports unchanged,--removetakes out only its own entries (a foreign hook survives), anddashboard --ambientprint…gerrit-axii…node scripts/generate-docs.mjs --check(generated README/docs regions vs catalog.yaml)node --test scripts/generate-docs.test.mjsgit ls-remote https://github.com/slnkjthien/gerrit-axi refs/tags/v0.4.0*(tag resolves to reviewed_revision)Cloned gerrit-axi at v0.4.0 and checked that every reviewed_components path existsgerrit-axi --version,-v,-Vin isolated HOMEgerrit-axibare, with no host and with an unreachable GERRIT_HOSTgerrit-axi status --bogus,status --limt 3,status 123 --fields nope,submit abcgerrit-axi status --help,setup --help,--helpgerrit-axi dashboard --ambientoutside a Gerrit checkoutgerrit-axi setup hooks, run again, then--remove, in isolated HOME; also with a pre-seeded foreign SessionStart hookgerrit-axi upstreamnode --test test/axi.test.js test/vote-ban.test.jsat v0.4.0✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.