Skip to content

Adjust stop bit condition in decode function#5

Merged
kulp merged 1 commit intokulp:masterfrom
ezrec:master
Apr 1, 2026
Merged

Adjust stop bit condition in decode function#5
kulp merged 1 commit intokulp:masterfrom
ezrec:master

Conversation

@ezrec
Copy link
Copy Markdown
Contributor

@ezrec ezrec commented Mar 31, 2026

Needed for when stop_bits is 1, instead of 2.

Needed for when stop_bits is 1, instead of 2.
@kulp
Copy link
Copy Markdown
Owner

kulp commented Apr 1, 2026

@ezrec Thanks; this change looks correct at first glance. I have not thought about this code in a long time.

Did you find the issue by inspection, or by some kind of concrete use? I would still expect minimodem to be fit for purpose more often than tynsel, but I would be happy to know if tynsel fit a need somewhere.

@kulp kulp merged commit f360ed6 into kulp:master Apr 1, 2026
2 checks passed
@ezrec
Copy link
Copy Markdown
Contributor Author

ezrec commented Apr 2, 2026

I would be happy to know if tynsel fit a need somewhere.

I’m using tynsel to get Wifi connection data to a ESP32 based wearable device. Tynsel was perfect for this, given its extremely low memory requirements.

The serial protocol I’m using for error correction expected 8-bit data, so I’m using 8N1 encoding, which highlighted the stop bit issue.

I’ve tried a few other audio receivers (quiet, ggwave) but tynsel fit my needs the best.

Thanks for all the work you put into it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants