Skip to content

Document VMI memory overhead status reporting#996

Open
Barakmor1 wants to merge 1 commit into
kubevirt:mainfrom
Barakmor1:memoryoverheadreporting
Open

Document VMI memory overhead status reporting#996
Barakmor1 wants to merge 1 commit into
kubevirt:mainfrom
Barakmor1:memoryoverheadreporting

Conversation

@Barakmor1
Copy link
Copy Markdown
Member

@Barakmor1 Barakmor1 commented May 25, 2026

Add docs for status.memory.memoryOverhead behind the VmiMemoryOverheadReport feature gate, including live migration behavior, under resources requests and limits and link from the virtual hardware memory overhead section.

Enhancement link: https://github.com/kubevirt/enhancements/blob/main/veps/sig-compute/156-vmi-memory-overhead-reporting/vmi-memory-overhead-reporting.md

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

Document VMI memory overhead status reporting

Add docs for status.memory.memoryOverhead behind the
VmiMemoryOverheadReport feature gate, including live migration
behavior, under resources requests and limits and link from the
virtual hardware memory overhead section.

Assisted-by: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: bmordeha <bmordeha@redhat.com>
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label May 25, 2026
@kubevirt-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign iholder101 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown
Contributor

@jean-edouard jean-edouard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but why is memory overhead documented in "virtual hardware"? It doesn't have much to do with it, and has everything to do with pod resources request/limits...
Should we maybe move the whole section there so we don't have to cross-reference?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants