Skip to content

net, nad ref: Update the GA version#992

Open
frenzyfriday wants to merge 1 commit into
kubevirt:mainfrom
frenzyfriday:nad-swap-ga
Open

net, nad ref: Update the GA version#992
frenzyfriday wants to merge 1 commit into
kubevirt:mainfrom
frenzyfriday:nad-swap-ga

Conversation

@frenzyfriday
Copy link
Copy Markdown
Contributor

With PR [1] LiveUpdateNADRef has graduated in 1.9

[1] kubevirt/kubevirt#17049

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

NONE

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label May 13, 2026
@kubevirt-bot kubevirt-bot requested review from EdDev and ormergi May 13, 2026 07:59
Copy link
Copy Markdown
Member

@orelmisan orelmisan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @frenzyfriday!

Comment thread docs/network/hotplug/nad_reference.md Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- The `LiveUpdateNADRef` [feature-gate](https://kubevirt.io/user-guide/operations/activating_feature_gates/#how-to-activate-a-feature-gate) must be enabled (only required for v1.8)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, updated here

With PR [1] LiveUpdateNADRef has graduated in 1.9

[1] kubevirt/kubevirt#17049

Signed-off-by: Ananya Banerjee <anbanerj@redhat.com>
@frenzyfriday
Copy link
Copy Markdown
Contributor Author

Last change addresses Orel's comment

Copy link
Copy Markdown
Member

@orelmisan orelmisan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/approve

@aburdenthehand Please let us know when it could be merged. Thanks.
/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2026
@kubevirt-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: orelmisan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2026
@aburdenthehand
Copy link
Copy Markdown
Member

/unhold
Thanks!

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants