Skip to content

feat: Document GuestAgentPing probe pausing via annotation (VEP 207)#990

Open
ksimon1 wants to merge 1 commit into
kubevirt:mainfrom
ksimon1:pause-guest-agent-probes
Open

feat: Document GuestAgentPing probe pausing via annotation (VEP 207)#990
ksimon1 wants to merge 1 commit into
kubevirt:mainfrom
ksimon1:pause-guest-agent-probes

Conversation

@ksimon1

@ksimon1 ksimon1 commented Apr 30, 2026

Copy link
Copy Markdown
Member

Do not merge until kubevirt/kubevirt#17664 is merged
What this PR does / why we need it:
Add documentation for the new kubevirt.io/pause-guest-agent-probes annotation that allows users to temporarily pause GuestAgentPing probes during maintenance operations such as guest OS updates. Covers usage instructions (pause, check status, resume) and important caveats including that the annotation is not intended for permanent probe disabling.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

feat: Document GuestAgentPing probe pausing via annotation (VEP 207)

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Apr 30, 2026
@kubevirt-bot kubevirt-bot requested review from dhiller and vladikr April 30, 2026 10:15

@jean-edouard jean-edouard left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Comment thread docs/user_workloads/liveness_and_readiness_probes.md Outdated
@kubevirt-bot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jean-edouard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2026
@jean-edouard

Copy link
Copy Markdown
Contributor

/hold
Depends on kubevirt/kubevirt#17664

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2026
@ksimon1 ksimon1 force-pushed the pause-guest-agent-probes branch from cc205bd to 7578839 Compare June 9, 2026 12:00
Add documentation for the new kubevirt.io/pause-guest-agent-probes
annotation that allows users to temporarily pause GuestAgentPing probes
during maintenance operations such as guest OS updates. Covers usage
instructions (pause, check status, resume) and important caveats
including that the annotation is not intended for permanent probe
disabling.

Signed-off-by: Karel Simon <ksimon@redhat.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants