Add phase-2 emulated SR-IOV presubmit by oshoval · Pull Request #5090 · kubevirt/project-infra

oshoval · 2026-05-26T13:05:50Z

What this PR does / why we need it:

Depends on sriov: Adapt SR-IOV tests for igb emulated environments kubevirt#16975
only first commit relevant, others are hack that need to be removed - don't review them please

Add a new k8s 1.36 sig-network emulated SR-IOV presubmit as a
phase-2 signal that runs before merge instead of always running.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:
Depends on kubevirt/kubevirt#16975
once we merge this lane, we can make kind-sriov optional.

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Design: A design document was considered and is present (link) or not required
PR: The PR description is expressive enough and will help future contributors
Code: Write code that humans can understand and Keep it simple
Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
Upgrade: Impact of this change on upgrade flows was considered and addressed if required
Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
Community: Announcement to kubevirt-dev was considered

Release note:

None

kubevirt-bot · 2026-05-26T13:05:53Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

kubevirt-bot · 2026-05-26T13:05:58Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jean-edouard for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

gemini-code-assist

Code Review

This pull request adds a new presubmit job, pull-kubevirt-e2e-k8s-1.36-sig-network-emulated-sriov, to the Prow configuration. The reviewer suggested reordering the keys in the job definition (specifically moving run_before_merge) to maintain alphabetical sorting consistency with the rest of the file.

oshoval · 2026-05-28T11:59:52Z

thanks Daniel !

oshoval · 2026-05-28T12:00:01Z

/rehearse

https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_project-infra/5090/rehearsal-pull-kubevirt-e2e-k8s-1.36-emulated-igb/2059967978388066304

kubevirt-bot · 2026-05-28T12:00:13Z

Rehearsal jobs created for this PR:

rehearsal-pull-kubevirt-e2e-k8s-1.36-emulated-igb

Further information on rehearsals

A rehearsal can be triggered for all jobs by commenting either /rehearse or /rehearse all on this PR.

A rehearsal for a specific job can be triggered by commenting /rehearse {job-name}.

Commenting /rehearse ? triggers a comment with a list of jobs that can be rehearsed.

A pull request can be rehearsed if either the user is authorized to rehearse or the pull
request has the ok-to-rehearse label.

Authorized users are the group of users that are members of the KubeVirt GitHub
organization AND either are approvers[1] for all files in the pull request or are
top-level approvers[1] in the project-infra project.

[1]: see OWNERS file definition for reference.

oshoval · 2026-05-28T13:04:30Z

https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_project-infra/5090/rehearsal-pull-kubevirt-e2e-k8s-1.36-emulated-igb/2059967978388066304

passed

oshoval · 2026-05-31T09:25:23Z

/hold

until kubevirt/kubevirt#16975 is merged
and DNM commits are dropped if any

do we want to make kind-sriov optional once this one is merged directly ?

oshoval · 2026-06-01T06:18:14Z

/rehearse

https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_project-infra/5090/rehearsal-pull-kubevirt-e2e-k8s-1.36-emulated-igb/2061331584929239040

failed due to NUMA bug (on it)

kubevirt-bot · 2026-06-01T06:18:44Z

Rehearsal jobs created for this PR:

rehearsal-pull-kubevirt-e2e-k8s-1.36-emulated-igb

Further information on rehearsals

A rehearsal can be triggered for all jobs by commenting either /rehearse or /rehearse all on this PR.

A rehearsal for a specific job can be triggered by commenting /rehearse {job-name}.

Commenting /rehearse ? triggers a comment with a list of jobs that can be rehearsed.

A pull request can be rehearsed if either the user is authorized to rehearse or the pull
request has the ok-to-rehearse label.

Authorized users are the group of users that are members of the KubeVirt GitHub
organization AND either are approvers[1] for all files in the pull request or are
top-level approvers[1] in the project-infra project.

[1]: see OWNERS file definition for reference.

oshoval · 2026-06-02T07:03:20Z

/rehearse

https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_project-infra/5090/rehearsal-pull-kubevirt-e2e-k8s-1.36-emulated-igb/2061705334824636416

passed with NUMA support

kubevirt-bot · 2026-06-02T07:03:53Z

Rehearsal jobs created for this PR:

rehearsal-pull-kubevirt-e2e-k8s-1.36-emulated-igb

Further information on rehearsals

A rehearsal can be triggered for all jobs by commenting either /rehearse or /rehearse all on this PR.

A rehearsal for a specific job can be triggered by commenting /rehearse {job-name}.

Commenting /rehearse ? triggers a comment with a list of jobs that can be rehearsed.

A pull request can be rehearsed if either the user is authorized to rehearse or the pull
request has the ok-to-rehearse label.

Authorized users are the group of users that are members of the KubeVirt GitHub
organization AND either are approvers[1] for all files in the pull request or are
top-level approvers[1] in the project-infra project.

[1]: see OWNERS file definition for reference.

ormergi · 2026-06-02T10:07:31Z

+      preset-podman-shared-images: "true"
+      preset-shared-images: "true"
+    max_concurrency: 11
+    name: pull-kubevirt-e2e-k8s-1.36-emulated-igb


Please change the name to refelct this is about testing SR-IOV with emulated HW, at least this is sig-network lane

pull-kubevirt-e2e-k8s-1.36-sig-network-sriov-emulated

explained here why it is wrong
kubevirt/kubevirt#16975 (comment)
lets please continue on one of them only

renamed the name

oshoval · 2026-06-04T07:18:33Z

/rehearse

wip: trying with alpine that has emulated SR-IOV

kubevirt-bot · 2026-06-04T07:19:34Z

Rehearsal jobs created for this PR:

rehearsal-pull-kubevirt-e2e-k8s-1.36-emulated-igb

Further information on rehearsals

A rehearsal can be triggered for all jobs by commenting either /rehearse or /rehearse all on this PR.

A rehearsal for a specific job can be triggered by commenting /rehearse {job-name}.

Commenting /rehearse ? triggers a comment with a list of jobs that can be rehearsed.

A pull request can be rehearsed if either the user is authorized to rehearse or the pull
request has the ok-to-rehearse label.

Authorized users are the group of users that are members of the KubeVirt GitHub
organization AND either are approvers[1] for all files in the pull request or are
top-level approvers[1] in the project-infra project.

[1]: see OWNERS file definition for reference.

oshoval · 2026-06-04T07:32:57Z

/rehearse

kubevirt-bot · 2026-06-04T07:33:34Z

Rehearsal jobs created for this PR:

rehearsal-pull-kubevirt-e2e-k8s-1.36-emulated-igb

Further information on rehearsals

A rehearsal can be triggered for all jobs by commenting either /rehearse or /rehearse all on this PR.

A rehearsal for a specific job can be triggered by commenting /rehearse {job-name}.

Commenting /rehearse ? triggers a comment with a list of jobs that can be rehearsed.

A pull request can be rehearsed if either the user is authorized to rehearse or the pull
request has the ok-to-rehearse label.

Authorized users are the group of users that are members of the KubeVirt GitHub
organization AND either are approvers[1] for all files in the pull request or are
top-level approvers[1] in the project-infra project.

[1]: see OWNERS file definition for reference.

oshoval · 2026-06-04T07:47:24Z

/rehearse

https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_project-infra/5090/rehearsal-pull-kubevirt-e2e-k8s-1.36-emulated-igb/2062441172915195904

kubevirt-bot · 2026-06-04T07:47:50Z

Rehearsal jobs created for this PR:

rehearsal-pull-kubevirt-e2e-k8s-1.36-emulated-igb

Further information on rehearsals

A rehearsal can be triggered for all jobs by commenting either /rehearse or /rehearse all on this PR.

A rehearsal for a specific job can be triggered by commenting /rehearse {job-name}.

Commenting /rehearse ? triggers a comment with a list of jobs that can be rehearsed.

A pull request can be rehearsed if either the user is authorized to rehearse or the pull
request has the ok-to-rehearse label.

Authorized users are the group of users that are members of the KubeVirt GitHub
organization AND either are approvers[1] for all files in the pull request or are
top-level approvers[1] in the project-infra project.

[1]: see OWNERS file definition for reference.

oshoval · 2026-06-04T09:11:00Z

/rehearse

kubevirt-bot · 2026-06-04T09:11:26Z

Rehearsal jobs created for this PR:

rehearsal-pull-kubevirt-e2e-k8s-1.36-emulated-igb

Further information on rehearsals

A rehearsal can be triggered for all jobs by commenting either /rehearse or /rehearse all on this PR.

A rehearsal for a specific job can be triggered by commenting /rehearse {job-name}.

Commenting /rehearse ? triggers a comment with a list of jobs that can be rehearsed.

A pull request can be rehearsed if either the user is authorized to rehearse or the pull
request has the ok-to-rehearse label.

Authorized users are the group of users that are members of the KubeVirt GitHub
organization AND either are approvers[1] for all files in the pull request or are
top-level approvers[1] in the project-infra project.

[1]: see OWNERS file definition for reference.

oshoval · 2026-06-04T09:14:44Z

/rehearse

kubevirt-bot · 2026-06-04T09:15:10Z

Rehearsal jobs created for this PR:

rehearsal-pull-kubevirt-e2e-k8s-1.36-emulated-igb

Further information on rehearsals

A rehearsal can be triggered for all jobs by commenting either /rehearse or /rehearse all on this PR.

A rehearsal for a specific job can be triggered by commenting /rehearse {job-name}.

Commenting /rehearse ? triggers a comment with a list of jobs that can be rehearsed.

A pull request can be rehearsed if either the user is authorized to rehearse or the pull
request has the ok-to-rehearse label.

Authorized users are the group of users that are members of the KubeVirt GitHub
organization AND either are approvers[1] for all files in the pull request or are
top-level approvers[1] in the project-infra project.

[1]: see OWNERS file definition for reference.

oshoval · 2026-06-04T10:22:31Z

/rehearse

all passed with alpine with igb and more required fixes
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_project-infra/5090/rehearsal-pull-kubevirt-e2e-k8s-1.36-emulated-igb/2062480237895094272

but it would be better to split the effort, as it require few additional steps / bugs

kubevirt-bot · 2026-06-04T10:23:04Z

Rehearsal jobs created for this PR:

rehearsal-pull-kubevirt-e2e-k8s-1.36-emulated-igb

Further information on rehearsals

A rehearsal can be triggered for all jobs by commenting either /rehearse or /rehearse all on this PR.

A rehearsal for a specific job can be triggered by commenting /rehearse {job-name}.

Commenting /rehearse ? triggers a comment with a list of jobs that can be rehearsed.

A pull request can be rehearsed if either the user is authorized to rehearse or the pull
request has the ok-to-rehearse label.

Authorized users are the group of users that are members of the KubeVirt GitHub
organization AND either are approvers[1] for all files in the pull request or are
top-level approvers[1] in the project-infra project.

[1]: see OWNERS file definition for reference.

Add a new k8s 1.36 sig-network emulated SR-IOV presubmit as a phase-2 signal that runs before merge instead of always running. Assisted-by: Cursor Signed-off-by: Or Shoval <oshoval@redhat.com>

Signed-off-by: Or Shoval <oshoval@redhat.com>

oshoval · 2026-06-09T05:22:05Z

renamed the name and rebased

kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 26, 2026

kubevirt-bot added the size/M label May 26, 2026

oshoval mentioned this pull request May 26, 2026

sriov: Adapt SR-IOV tests for igb emulated environments kubevirt/kubevirt#16975

Open

9 tasks

gemini-code-assist Bot reviewed May 26, 2026

View reviewed changes

Comment thread github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/kubevirt-presubmits.yaml

oshoval force-pushed the esriov branch 3 times, most recently from 9a49ef5 to ba09dc3 Compare May 28, 2026 11:49

dhiller added the ok-to-rehearse Label to enable rehearsals of pull requests for which the author is not allowed label May 28, 2026

oshoval marked this pull request as ready for review May 28, 2026 11:59

kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 28, 2026

kubevirt-bot requested review from EdDev and victortoso May 28, 2026 11:59

oshoval changed the title ~~ci: add phase-2 emulated SR-IOV sig-network presubmit~~ WIP ci: add phase-2 emulated SR-IOV sig-network presubmit May 28, 2026

kubevirt-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 28, 2026

oshoval force-pushed the esriov branch from ba09dc3 to caff1fb Compare May 28, 2026 13:04

oshoval changed the title ~~WIP ci: add phase-2 emulated SR-IOV sig-network presubmit~~ ci: add phase-2 emulated SR-IOV sig-network presubmit May 28, 2026

kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 28, 2026

oshoval marked this pull request as draft May 28, 2026 13:04

kubevirt-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 28, 2026

kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 31, 2026

oshoval marked this pull request as ready for review May 31, 2026 09:25

kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 31, 2026

oshoval force-pushed the esriov branch from caff1fb to 783111c Compare May 31, 2026 09:25

kubevirt-bot requested review from mhenriks and xpivarc May 31, 2026 09:26

oshoval changed the title ~~ci: add phase-2 emulated SR-IOV sig-network presubmit~~ Add phase-2 emulated SR-IOV presubmit Jun 2, 2026

ormergi reviewed Jun 2, 2026

View reviewed changes

oshoval force-pushed the esriov branch from 70dfda9 to 4df376f Compare June 4, 2026 07:46

oshoval force-pushed the esriov branch 2 times, most recently from bb23c46 to 28587ff Compare June 9, 2026 05:20

oshoval added 2 commits June 9, 2026 08:20

ci: add phase-2 emulated SR-IOV sig-network presubmit

cedef58

Add a new k8s 1.36 sig-network emulated SR-IOV presubmit as a phase-2 signal that runs before merge instead of always running. Assisted-by: Cursor Signed-off-by: Or Shoval <oshoval@redhat.com>

DNM: allow to test it

0a3732c

Signed-off-by: Or Shoval <oshoval@redhat.com>

oshoval force-pushed the esriov branch from 28587ff to 0a3732c Compare June 9, 2026 05:20

Conversation

oshoval commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kubevirt-bot commented May 26, 2026

Uh oh!

kubevirt-bot commented May 26, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

oshoval commented May 28, 2026

Uh oh!

oshoval commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kubevirt-bot commented May 28, 2026

Uh oh!

oshoval commented May 28, 2026

Uh oh!

oshoval commented May 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oshoval commented Jun 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kubevirt-bot commented Jun 1, 2026

Uh oh!

oshoval commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kubevirt-bot commented Jun 2, 2026

Uh oh!

ormergi Jun 2, 2026

Choose a reason for hiding this comment

Uh oh!

oshoval Jun 2, 2026

Choose a reason for hiding this comment

Uh oh!

oshoval Jun 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oshoval commented Jun 4, 2026

Uh oh!

kubevirt-bot commented Jun 4, 2026

Uh oh!

oshoval commented Jun 4, 2026

Uh oh!

kubevirt-bot commented Jun 4, 2026

Uh oh!

oshoval commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kubevirt-bot commented Jun 4, 2026

Uh oh!

oshoval commented Jun 4, 2026

Uh oh!

kubevirt-bot commented Jun 4, 2026

Uh oh!

oshoval commented Jun 4, 2026

Uh oh!

kubevirt-bot commented Jun 4, 2026

Uh oh!

oshoval commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kubevirt-bot commented Jun 4, 2026

Uh oh!

oshoval commented Jun 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

oshoval commented May 26, 2026 •

edited

Loading

oshoval commented May 28, 2026 •

edited

Loading

oshoval commented May 31, 2026 •

edited

Loading

oshoval commented Jun 1, 2026 •

edited

Loading

oshoval commented Jun 2, 2026 •

edited

Loading

oshoval Jun 8, 2026 •

edited

Loading

oshoval commented Jun 4, 2026 •

edited

Loading

oshoval commented Jun 4, 2026 •

edited

Loading