Skip to content

ci: remove KUBEVIRT_ONLY_USE_TAGS, since is no longer used#5089

Open
nestoracunablanco wants to merge 1 commit into
kubevirt:mainfrom
nestoracunablanco:ci/standardizeS390xCommonInstanceTypes
Open

ci: remove KUBEVIRT_ONLY_USE_TAGS, since is no longer used#5089
nestoracunablanco wants to merge 1 commit into
kubevirt:mainfrom
nestoracunablanco:ci/standardizeS390xCommonInstanceTypes

Conversation

@nestoracunablanco

Copy link
Copy Markdown
Contributor

The implementation of KUBEVIRT_ONY_USE_TAGS has been removed, hence the definition deletion in the ci jobs.
Furthermore standardize GIMME_GO_VERSION by calling directly go.mod using the environment variable GO_MOD_PATH.

The implementation of KUBEVIRT_ONY_USE_TAGS has been removed,
hence the definition deletion in the ci jobs.
Furthermore standardize GIMME_GO_VERSION by calling directly
go.mod using the environment variable GO_MOD_PATH.

Signed-off-by: nestoracunablanco <nestor.acuna@ibm.com>
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label May 26, 2026
@kubevirt-bot kubevirt-bot requested review from codingben and ksimon1 May 26, 2026 12:25
@kubevirt-bot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign 0xfelix for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cleans up the CI job configurations in common-instancetypes-presubmits.yaml by removing the KUBEVIRT_ONLY_USE_TAGS environment variable across multiple presubmit jobs. Additionally, it replaces the GIMME_GO_VERSION environment variable with GO_MOD_PATH set to "go.mod" in several job definitions. There are no review comments to address.

@nestoracunablanco

Copy link
Copy Markdown
Contributor Author

/test pull-project-infra-prow-deploy-test

@Whitedyl Whitedyl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks @nestoracunablanco !

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2026
@nestoracunablanco

Copy link
Copy Markdown
Contributor Author

/rehearse

@kubevirt-bot

Copy link
Copy Markdown
Contributor

⚠️ @nestoracunablanco you need to be an approver for all the files to run rehearsal.

@lyarwood can help run the rehearsal.

Details

If that doesn't work, ping someone from this list:

  • dhiller
  • enp0s3
  • phoracek
  • rmohr
  • tiraboschi
  • aglitke
  • davidvossel
  • dollierp
  • vladikr
  • xpivarc

@kubevirt-bot

Copy link
Copy Markdown
Contributor

Pull requests that are marked with lgtm should receive a review
from an approver within 1 week.

After that period the bot marks them with the label needs-approver-review.

/label needs-approver-review

@kubevirt-bot kubevirt-bot added the needs-approver-review Indicates that a PR requires a review from an approver. label Jun 8, 2026
@nestoracunablanco

Copy link
Copy Markdown
Contributor Author

Hi @dhiller could you please run a rehearsal? Thanks :)

@lyarwood

lyarwood commented Jun 9, 2026

Copy link
Copy Markdown
Member

/rehearse

@kubevirt-bot

Copy link
Copy Markdown
Contributor

Rehearsal jobs created for this PR:

rehearsal-pull-common-instancetypes-functest-stream-9-s390x
rehearsal-pull-common-instancetypes-functest-stream-10-s390x
rehearsal-pull-common-instancetypes-opensuse-tumbleweed-s390x
rehearsal-pull-common-instancetypes-functest-fedora-s390x
Further information on rehearsals

A rehearsal can be triggered for all jobs by commenting either /rehearse or /rehearse all on this PR.

A rehearsal for a specific job can be triggered by commenting /rehearse {job-name}.

Commenting /rehearse ? triggers a comment with a list of jobs that can be rehearsed.

A pull request can be rehearsed if either the user is authorized to rehearse or the pull
request has the ok-to-rehearse label.

Authorized users are the group of users that are members of the KubeVirt GitHub
organization AND either are approvers[1] for all files in the pull request or are
top-level approvers[1] in the project-infra project.

[1]: see OWNERS file definition for reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. needs-approver-review Indicates that a PR requires a review from an approver. size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants