ci: remove KUBEVIRT_ONLY_USE_TAGS, since is no longer used#5089
ci: remove KUBEVIRT_ONLY_USE_TAGS, since is no longer used#5089nestoracunablanco wants to merge 1 commit into
Conversation
The implementation of KUBEVIRT_ONY_USE_TAGS has been removed, hence the definition deletion in the ci jobs. Furthermore standardize GIMME_GO_VERSION by calling directly go.mod using the environment variable GO_MOD_PATH. Signed-off-by: nestoracunablanco <nestor.acuna@ibm.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Code Review
This pull request cleans up the CI job configurations in common-instancetypes-presubmits.yaml by removing the KUBEVIRT_ONLY_USE_TAGS environment variable across multiple presubmit jobs. Additionally, it replaces the GIMME_GO_VERSION environment variable with GO_MOD_PATH set to "go.mod" in several job definitions. There are no review comments to address.
|
/test pull-project-infra-prow-deploy-test |
Whitedyl
left a comment
There was a problem hiding this comment.
/lgtm
Thanks @nestoracunablanco !
|
/rehearse |
|
@lyarwood can help run the rehearsal. DetailsIf that doesn't work, ping someone from this list:
|
|
Pull requests that are marked with After that period the bot marks them with the label /label needs-approver-review |
|
Hi @dhiller could you please run a rehearsal? Thanks :) |
|
/rehearse |
|
Rehearsal jobs created for this PR: Further information on rehearsalsA rehearsal can be triggered for all jobs by commenting either A rehearsal for a specific job can be triggered by commenting Commenting A pull request can be rehearsed if either the user is authorized to rehearse or the pull Authorized users are the group of users that are members of the KubeVirt GitHub [1]: see OWNERS file definition for reference. |
The implementation of KUBEVIRT_ONY_USE_TAGS has been removed, hence the definition deletion in the ci jobs.
Furthermore standardize GIMME_GO_VERSION by calling directly go.mod using the environment variable GO_MOD_PATH.