aaq,presubmits: Add unit-test for s390x by jschintag · Pull Request #4886 · kubevirt/project-infra

jschintag · 2026-03-30T11:57:09Z

Add a new test lane running unit-tests for aaq on s390x.

What this PR does / why we need it:
Add s390x unit-test lane for aaq

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Design: A design document was considered and is present (link) or not required
PR: The PR description is expressive enough and will help future contributors
Code: Write code that humans can understand and Keep it simple
Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
Upgrade: Impact of this change on upgrade flows was considered and addressed if required
Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
Community: Announcement to kubevirt-dev was considered

Release note:

NONE

/cc @Barakmor1

kubevirt-bot · 2026-03-30T11:57:18Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign vladikr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

github/ci/prow-deploy/files/jobs/kubevirt/application-aware-quota/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sourcery-ai

Hey - I've left some high level feedback:

The new pull-aaq-unit-test-s390x job defines resources: requests: without any keys under it, which will make the YAML invalid or at least misleading; either remove the empty resources block or populate it with concrete CPU/memory requests similar to the other lanes.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The new `pull-aaq-unit-test-s390x` job defines `resources:
  requests:` without any keys under it, which will make the YAML invalid or at least misleading; either remove the empty `resources` block or populate it with concrete CPU/memory requests similar to the other lanes.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

jschintag · 2026-03-31T06:26:14Z

/rehearse

kubevirt-bot · 2026-03-31T06:26:32Z

⚠️ @jschintag you need to be an approver for all the files to run rehearsal.

@vladikr can help run the rehearsal.

Details

If that doesn't work, ping someone from this list:

aglitke
dollierp
enp0s3
phoracek
rmohr
tiraboschi
davidvossel
dhiller
vladikr
xpivarc

jschintag · 2026-04-09T11:34:35Z

/retest-required

jschintag · 2026-04-21T11:23:05Z

@Barakmor1 could you PTAL?

jschintag · 2026-04-30T06:48:11Z

Rebased on on main

Barakmor1 · 2026-04-30T06:58:35Z

@dollierp any idea how can we trigger it?

Edit: nevermind seems like rehearse pull-aaq-unit-test-s390x worked

Barakmor1 · 2026-04-30T06:59:06Z

/rehearse pull-aaq-unit-test-s390x

kubevirt-bot · 2026-04-30T06:59:24Z

Rehearsal jobs created for this PR:

rehearsal-pull-aaq-unit-test-s390x

Further information on rehearsals

A rehearsal can be triggered for all jobs by commenting either /rehearse or /rehearse all on this PR.

A rehearsal for a specific job can be triggered by commenting /rehearse {job-name}.

Commenting /rehearse ? triggers a comment with a list of jobs that can be rehearsed.

A pull request can be rehearsed if either the user is authorized to rehearse or the pull
request has the ok-to-rehearse label.

Authorized users are the group of users that are members of the KubeVirt GitHub
organization AND either are approvers[1] for all files in the pull request or are
top-level approvers[1] in the project-infra project.

[1]: see OWNERS file definition for reference.

jschintag · 2026-04-30T07:51:47Z

There seems to be a problem with the cluster setup, the pod is stuck on init:

Events:
  Type     Reason       Age                   From               Message
  ----     ------       ----                  ----               -------
  Normal   Scheduled    51m                   default-scheduler  Successfully assigned kubevirt-prow-jobs/32c84e7d-06b2-448e-9990-0b07338737b4 to kubevirt01
  Warning  FailedMount  4m21s (x31 over 51m)  kubelet            MountVolume.SetUp failed for volume "docker-config" : configmap "docker-daemon-mirror-config" not found
  Warning  FailedMount  17s (x33 over 51m)    kubelet            MountVolume.SetUp failed for volume "docker-mirror-proxy-ca-cert" : configmap "mirror-proxy-config" not found

jschintag · 2026-04-30T07:57:05Z

/rehearse pull-aaq-unit-test-s390x

kubevirt-bot · 2026-04-30T07:57:21Z

⚠️ @jschintag you need to be an approver for all the files to run rehearsal.

@Barakmor1 can help run the rehearsal.

Details

If that doesn't work, ping someone from this list:

tiraboschi
phoracek
vladikr
xpivarc
aglitke
davidvossel
dhiller
dollierp
enp0s3
rmohr

dollierp · 2026-04-30T07:57:48Z

/rehearse pull-aaq-unit-test-s390x

kubevirt-bot · 2026-04-30T07:58:04Z

Rehearsal jobs created for this PR:

rehearsal-pull-aaq-unit-test-s390x

Further information on rehearsals

A rehearsal can be triggered for all jobs by commenting either /rehearse or /rehearse all on this PR.

A rehearsal for a specific job can be triggered by commenting /rehearse {job-name}.

Commenting /rehearse ? triggers a comment with a list of jobs that can be rehearsed.

A pull request can be rehearsed if either the user is authorized to rehearse or the pull
request has the ok-to-rehearse label.

Authorized users are the group of users that are members of the KubeVirt GitHub
organization AND either are approvers[1] for all files in the pull request or are
top-level approvers[1] in the project-infra project.

[1]: see OWNERS file definition for reference.

Add a new test lane running unit-tests for aaq on s390x. Signed-off-by: Jan Schintag <jan.schintag@de.ibm.com>

dollierp · 2026-04-30T09:13:03Z

/rehearse pull-aaq-unit-test-s390x

kubevirt-bot · 2026-04-30T09:13:14Z

Rehearsal jobs created for this PR:

rehearsal-pull-aaq-unit-test-s390x

Further information on rehearsals

A rehearsal can be triggered for all jobs by commenting either /rehearse or /rehearse all on this PR.

A rehearsal for a specific job can be triggered by commenting /rehearse {job-name}.

Commenting /rehearse ? triggers a comment with a list of jobs that can be rehearsed.

A pull request can be rehearsed if either the user is authorized to rehearse or the pull
request has the ok-to-rehearse label.

Authorized users are the group of users that are members of the KubeVirt GitHub
organization AND either are approvers[1] for all files in the pull request or are
top-level approvers[1] in the project-infra project.

[1]: see OWNERS file definition for reference.

jschintag · 2026-05-12T06:52:00Z

@Barakmor1 the test is passing and optional. Could you PTAL again?

Barakmor1 · 2026-05-12T06:56:06Z

Thank you!
/lgtm

jschintag · 2026-05-12T06:59:36Z

Thank you @Barakmor1.

/cc @vladikr
Could you PTAL?

kubevirt-bot · 2026-05-19T07:16:41Z

Pull requests that are marked with lgtm should receive a review
from an approver within 1 week.

After that period the bot marks them with the label needs-approver-review.

/label needs-approver-review

kubevirt-bot requested a review from Barakmor1 March 30, 2026 11:57

kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Mar 30, 2026

kubevirt-bot added the size/M label Mar 30, 2026

sourcery-ai Bot reviewed Mar 30, 2026

View reviewed changes

jschintag force-pushed the aaq-unit-tests-s390x branch from 7643519 to ff13f88 Compare April 30, 2026 06:47

dollierp reviewed Apr 30, 2026

View reviewed changes

Comment thread ...w-deploy/files/jobs/kubevirt/application-aware-quota/application-aware-quota-presubmits.yaml Outdated

jschintag force-pushed the aaq-unit-tests-s390x branch from ff13f88 to 25fdf8d Compare April 30, 2026 07:56

Barakmor1 reviewed Apr 30, 2026

View reviewed changes

Comment thread ...w-deploy/files/jobs/kubevirt/application-aware-quota/application-aware-quota-presubmits.yaml Outdated

aaq,presubmits: Add unit-test for s390x

4c63714

Add a new test lane running unit-tests for aaq on s390x. Signed-off-by: Jan Schintag <jan.schintag@de.ibm.com>

jschintag force-pushed the aaq-unit-tests-s390x branch from 25fdf8d to 4c63714 Compare April 30, 2026 08:56

kubevirt-bot assigned Barakmor1 May 12, 2026

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2026

kubevirt-bot requested a review from vladikr May 12, 2026 06:59

kubevirt-bot added the needs-approver-review Indicates that a PR requires a review from an approver. label May 19, 2026

Conversation

jschintag commented Mar 30, 2026

Uh oh!

kubevirt-bot commented Mar 30, 2026

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

jschintag commented Mar 31, 2026

Uh oh!

kubevirt-bot commented Mar 31, 2026

Uh oh!

jschintag commented Apr 9, 2026

Uh oh!

jschintag commented Apr 21, 2026

Uh oh!

jschintag commented Apr 30, 2026

Uh oh!

Barakmor1 commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Barakmor1 commented Apr 30, 2026

Uh oh!

kubevirt-bot commented Apr 30, 2026

Uh oh!

jschintag commented Apr 30, 2026

Uh oh!

Uh oh!

jschintag commented Apr 30, 2026

Uh oh!

kubevirt-bot commented Apr 30, 2026

Uh oh!

dollierp commented Apr 30, 2026

Uh oh!

kubevirt-bot commented Apr 30, 2026

Uh oh!

Uh oh!

dollierp commented Apr 30, 2026

Uh oh!

kubevirt-bot commented Apr 30, 2026

Uh oh!

jschintag commented May 12, 2026

Uh oh!

Barakmor1 commented May 12, 2026

Uh oh!

jschintag commented May 12, 2026

Uh oh!

kubevirt-bot commented May 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Barakmor1 commented Apr 30, 2026 •

edited

Loading