Add ghprojects: declarative GitHub Projects V2 management by lyarwood · Pull Request #4815 · kubevirt/project-infra

lyarwood · 2026-03-11T09:24:34Z

Summary

Scaffolds a new pkg/ghprojects package and robots/ghprojects CLI for managing GitHub Projects V2 boards declaratively from YAML configuration
Follows the same desired-state reconciliation pattern as peribolos: dry-run by default, --confirm to apply, granular --fix-projects/--fix-fields/--fix-views flags
Uses the shurcooL/githubv4 GraphQL library already vendored in this repo
Includes a dump subcommand to export live project state back to YAML

kubevirt-bot · 2026-03-11T09:24:48Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign davidvossel for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sourcery-ai

Hey - I've found 3 issues, and left some high level feedback:

In client.GetOrgID, q.Organization.ID is a githubv4.ID, so q.Organization.ID.(string) will panic/does not compile; it should be converted with string(q.Organization.ID) to match how IDs are handled elsewhere.
In updateProject, you pre-fetch fields and views via GetProjectFields/GetProjectViews and assign them to actual, but reconcileFields/reconcileViews immediately call those methods again; consider passing the already-fetched data into the reconcile functions to avoid redundant API calls.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In `client.GetOrgID`, `q.Organization.ID` is a `githubv4.ID`, so `q.Organization.ID.(string)` will panic/does not compile; it should be converted with `string(q.Organization.ID)` to match how IDs are handled elsewhere.
- In `updateProject`, you pre-fetch fields and views via `GetProjectFields`/`GetProjectViews` and assign them to `actual`, but `reconcileFields`/`reconcileViews` immediately call those methods again; consider passing the already-fetched data into the reconcile functions to avoid redundant API calls.

## Individual Comments

### Comment 1
<location path="pkg/ghprojects/client/client.go" line_range="32" />
<code_context>
+	if err := c.gql.Query(ctx, &q, vars); err != nil {
+		return "", fmt.Errorf("querying org ID for %s: %w", login, err)
+	}
+	return q.Organization.ID.(string), nil
+}
+
</code_context>
<issue_to_address>
**issue (bug_risk):** Avoid unsafe type assertion when converting githubv4.ID to string

`q.Organization.ID` is a `githubv4.ID`, not an interface, so `.(string)` will panic. Use `string(q.Organization.ID)` instead to convert safely and avoid a runtime panic.
</issue_to_address>

### Comment 2
<location path="pkg/ghprojects/reconcile/reconcile.go" line_range="13-17" />
<code_context>
+	"kubevirt.io/project-infra/pkg/ghprojects/config"
+)
+
+// Options controls reconciliation behavior.
+type Options struct {
+	Confirm     bool // If false, dry-run only (log what would happen).
+	FixProjects bool // Create/update projects.
+	FixFields   bool // Create/update/delete custom fields.
+	FixViews    bool // Create/update views.
+}
</code_context>
<issue_to_address>
**issue:** Options comment overstates current field reconciliation capabilities

`FixFields` is documented as "Create/update/delete custom fields", but `reconcileFields` only creates missing fields and logs type mismatches; it doesn’t handle renames, option changes, or deletions. Please either adjust the comment to describe the current behavior or extend the implementation to match the option name/description so `--fix-fields` isn’t misleading.
</issue_to_address>

### Comment 3
<location path="pkg/ghprojects/dump/dump.go" line_range="64-65" />
<code_context>
+			})
+		}
+
+		key := slugify(p.Title)
+		orgProjects.Projects[key] = proj
+	}
+
</code_context>
<issue_to_address>
**issue (bug_risk):** Slug generation can lead to empty or colliding project keys

Using `slugify(p.Title)` as the map key can yield an empty string (titles without alphanumerics) or collisions (different titles normalizing to the same slug), which will silently overwrite entries in `orgProjects.Projects`. Consider detecting empty/colliding slugs and either deriving a unique key (e.g., append project number) or returning an error so callers can handle it.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

Scaffolds a new package and CLI tool for managing GitHub Projects V2 boards from YAML configuration, following the same desired-state reconciliation pattern as peribolos. Includes: - config: YAML types and loader with validation - client: GitHub GraphQL API wrapper for Projects V2 (projects, fields, views) - reconcile: desired-state reconciler with dry-run, per-resource fix flags - dump: export live GitHub project state back to YAML - robots/ghprojects: CLI entrypoint with sync and dump subcommands Assisted-By: Claude <noreply@anthropic.com> Signed-off-by: Lee Yarwood <lyarwood@redhat.com>

lyarwood · 2026-03-11T09:36:22Z

All three review comments have been addressed in the latest force-push:

Unsafe type assertion — GetOrgID now uses a safe comma-ok assertion with an error return
Redundant API calls — reconcileFields/reconcileViews now accept pre-fetched data as parameters instead of re-fetching
FixFields comment — updated to accurately say "Create missing custom fields"
Slug collisions — empty slugs fall back to project-<number>, collisions get the number appended as suffix

kubevirt-bot · 2026-05-07T15:43:38Z

There has been no activity on this PR for 45 days.
To protect limited CI resources, it has been automatically labelled 'stale'.
This PR will automatically rot after an additional 14 days of inactivity, and will be closed shortly after that.

What you can do:

If the PR is waiting on you to respond to a question or feedback and/or update the PR, please do so.
You can mark the PR as fresh and remove the label with the following command: /remove-lifecycle stale
If this PR is safe to close now, please help the project by closing it with: /close
If you need attention on this PR from a reviewer, you can raise it on the agenda of the relevant SIG meeting or KubeVirt Community meeting, or ping the kubevirt-dev slack channel.

/lifecycle stale

kubevirt-bot · 2026-05-21T16:20:48Z

There has been no activity on this PR for 59 days and it has been stale for 14 days.
To protect limited CI resources, it has been automatically labelled 'rotten' and will be closed in 7 days.

What you can do:

If the PR is waiting on you to respond to a question or feedback and/or update the PR, please do so.
You can mark the PR as fresh and remove the label with the following command: /remove-lifecycle rotten
If this PR is safe to close now, please help the project by closing it with: /close
If you need attention on this PR from a reviewer, you can raise it on the agenda of the relevant SIG meeting or KubeVirt Community meeting, or ping the kubevirt-dev slack channel.

/lifecycle rotten

kubevirt-bot · 2026-05-28T16:36:56Z

There has been no activity on this PR for 66 days and it has been rotten for 7 days.
To protect limited CI resources, it has been automatically closed.

What you can do:

If the PR is waiting on you to respond to a question or feedback and/or update the PR, please do so.
You can reopen the PR with the following command: /reopen
Raise attention on this PR at a relevant SIG meeting or KubeVirt Community meeting, or ping the kubevirt-dev slack channel.

/close

kubevirt-bot · 2026-05-28T16:37:01Z

@kubevirt-bot: Closed this PR.

Details

In response to this:

There has been no activity on this PR for 66 days and it has been rotten for 7 days.
To protect limited CI resources, it has been automatically closed.

What you can do:

If the PR is waiting on you to respond to a question or feedback and/or update the PR, please do so.

You can reopen the PR with the following command: /reopen

Raise attention on this PR at a relevant SIG meeting or KubeVirt Community meeting, or ping the kubevirt-dev slack channel.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

dhiller · 2026-06-02T14:46:30Z

/reopen
/remove-lifecycle rotten

kubevirt-bot · 2026-06-02T14:46:44Z

@dhiller: Reopened this PR.

Details

In response to this:

/reopen
/remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

dhiller

Thank you @lyarwood!

I've only done a quick review, will follow up with a more thorough one later. Some nit comments inline.

dhiller · 2026-06-02T14:51:35Z

+
+// OrgProjects holds all project definitions for a single GitHub organization.
+type OrgProjects struct {
+	Projects map[string]Project `yaml:"projects"`


nit: Why do we need a map here? Wouldn't a slice be enough? Or has the key a specific use?

dhiller · 2026-06-02T15:15:06Z

+			})
+		}
+
+		key := slugify(p.Title)


nit: if the key wasn't necessary we wouldn't need the func

dhiller · 2026-06-02T15:21:19Z

nit: wouldn't that rather belong inside config package?

kubevirt-bot added the dco-signoff: no Indicates the PR's author has not DCO signed all their commits. label Mar 11, 2026

kubevirt-bot added the size/XXL label Mar 11, 2026

kubevirt-bot requested review from dhiller and enp0s3 March 11, 2026 09:24

lyarwood force-pushed the ghprojects-scaffold branch from 931e49a to 9dae116 Compare March 11, 2026 09:25

kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Mar 11, 2026

sourcery-ai Bot reviewed Mar 11, 2026

View reviewed changes

Comment thread pkg/ghprojects/client/client.go Outdated

Comment thread pkg/ghprojects/reconcile/reconcile.go Outdated

Comment thread pkg/ghprojects/dump/dump.go

kubevirt-bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. and removed dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Mar 11, 2026

lyarwood force-pushed the ghprojects-scaffold branch from 0f2772a to 5bfcacd Compare March 11, 2026 09:35

kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Mar 11, 2026

lyarwood mentioned this pull request Mar 11, 2026

Track and surface VEP Owner, Approvers and Reviewers on project board and CC into impl PRs kubevirt-agents/vep-police-agent#17

Open

kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 7, 2026

kubevirt-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 21, 2026

kubevirt-bot closed this May 28, 2026

kubevirt-bot reopened this Jun 2, 2026

kubevirt-bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jun 2, 2026

dhiller reviewed Jun 2, 2026

View reviewed changes

Conversation

lyarwood commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

kubevirt-bot commented Mar 11, 2026

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lyarwood commented Mar 11, 2026

Uh oh!

kubevirt-bot commented May 7, 2026

Uh oh!

kubevirt-bot commented May 21, 2026

Uh oh!

kubevirt-bot commented May 28, 2026

Uh oh!

kubevirt-bot commented May 28, 2026

Uh oh!

dhiller commented Jun 2, 2026

Uh oh!

kubevirt-bot commented Jun 2, 2026

Uh oh!

dhiller left a comment

Choose a reason for hiding this comment

Uh oh!

dhiller Jun 2, 2026

Choose a reason for hiding this comment

Uh oh!

dhiller Jun 2, 2026

Choose a reason for hiding this comment

Uh oh!

dhiller Jun 2, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lyarwood commented Mar 11, 2026 •

edited

Loading