Skip to content

Conversation

@DerekFrank
Copy link
Contributor

Fixes #N/A

Description

This metric has nothing to do with nodes, it belongs in the pod subsystem.

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 2, 2026
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 2, 2026
@ellistarn
Copy link
Contributor

If we're comfortable with a breaking change on the metrics, use feat! so that the release notes get genned correctly.

@DerekFrank DerekFrank changed the title feat: move evictions total metric to pods subsystem feat!: move evictions total metric to pods subsystem Jan 5, 2026
@DerekFrank DerekFrank changed the title feat!: move evictions total metric to pods subsystem feat!: move evictions_total metric to pods subsystem Jan 5, 2026
@DerekFrank
Copy link
Contributor Author

/retest

@DerekFrank
Copy link
Contributor Author

/test all

@k8s-ci-robot
Copy link
Contributor

@DerekFrank: No jobs can be run with /test all.
The following commands are available to trigger optional jobs:

/test pull-karpenter-test-1-26
/test pull-karpenter-test-1-27
/test pull-karpenter-test-1-28
/test pull-karpenter-test-1-29
Details

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor Author

@DerekFrank DerekFrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

@coveralls
Copy link

Pull Request Test Coverage Report for Build 20733284589

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 80.468%

Files with Coverage Reduction New Missed Lines %
pkg/controllers/disruption/consolidation.go 4 88.0%
Totals Coverage Status
Change from base Build 20733042356: 0.04%
Covered Lines: 11976
Relevant Lines: 14883

💛 - Coveralls

Copy link
Contributor

@ellistarn ellistarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DerekFrank, ellistarn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [DerekFrank,ellistarn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 713a6fb into kubernetes-sigs:main Jan 6, 2026
16 checks passed
@DerekFrank DerekFrank deleted the pod-eviction-metric branch January 8, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants