-
Notifications
You must be signed in to change notification settings - Fork 407
feat!: move evictions_total metric to pods subsystem #2757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: move evictions_total metric to pods subsystem #2757
Conversation
|
If we're comfortable with a breaking change on the metrics, use feat! so that the release notes get genned correctly. |
|
/retest |
|
/test all |
|
@DerekFrank: No jobs can be run with DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
DerekFrank
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/retest
Pull Request Test Coverage Report for Build 20733284589Details
💛 - Coveralls |
ellistarn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DerekFrank, ellistarn The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #N/A
Description
This metric has nothing to do with nodes, it belongs in the pod subsystem.
How was this change tested?
make presubmitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.