-
Notifications
You must be signed in to change notification settings - Fork 646
Fix BackendTLSPolicy conflict resolution to use namespace/name #4393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix BackendTLSPolicy conflict resolution to use namespace/name #4393
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Welcome @neeraj542! |
|
Hi @neeraj542. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: howardjohn, neeraj542 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Update conflict resolution documentation to use {namespace}/{name} instead
of {name} for alphabetical ordering, preventing two policies with the same
name in different namespaces from being considered identical.
0d886fe to
ba8d911
Compare
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes a subtle issue in BackendTLSPolicy conflict resolution where the documentation specified alphabetical ordering by
{name}only, which could allow two policies with the same name in different namespaces to be considered identical. This PR updates the conflict resolution to use{namespace}/{name}instead, making it consistent with other Gateway API resources (as specified in GEP-713) and ensuring proper conflict resolution across namespaces.Which issue(s) this PR fixes:
Fixes #4392
Does this PR introduce a user-facing change?:ote
Fix BackendTLSPolicy conflict resolution to use namespace/name instead of name for alphabetical ordering, ensuring policies with the same name in different namespaces are properly distinguished.