-
Notifications
You must be signed in to change notification settings - Fork 652
conformance: added tests for invalid backend TLS configuration #4389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
conformance: added tests for invalid backend TLS configuration #4389
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: snorwin The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
e5b6cd2 to
3c48b29
Compare
kl52752
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nit otherwise LGTM :)
…teway ResolvedRefs condition Signed-off-by: Norwin Schnyder <[email protected]>
3c48b29 to
8afa32e
Compare
|
/test pull-gateway-api-verify |
|
@snorwin Will test after the holidays. |
|
@snorwin Looks like we have a couple issues on the NGINX side that we need to fix regarding these conditions. |
|
|
||
| kubernetes.GatewayMustHaveCondition(t, s.Client, s.TimeoutConfig, tc.gatewayNamespacedName, metav1.Condition{ | ||
| Type: string(gatewayv1.GatewayConditionAccepted), | ||
| Status: metav1.ConditionTrue, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So even with an invalid configuration, the Gateway is still Accepted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This condition does not directly impact the Gateway's Accepted or Programmed conditions.
https://github.com/kubernetes-sigs/gateway-api/blob/main/apis/v1/gateway_types.go#L1265
Given the semantics we defined, yes this is the main reason we introduced a dedicated ResolvedRefs status condition.
What type of PR is this?
/kind test
/area conformance-test
What this PR does / why we need it:
This PR follows up on #4195 and #4123 by implementing conformance tests that validate the behavior of an invalid
ClientCertificateRefand theResolvedRefscondition on theGateway.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: