Skip to content

Conversation

@georgeedward2000
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds foundational infrastructure to support CIDR prefix-based NSG rules and prepares for the CLB DiffTracker Engine work. It includes:

  1. Security Group Enhancements: Add support for CIDR prefix parameters in NSG rule methods (AddRuleForAllowedServiceTag, AddRuleForAllowedIPRanges, AddRuleForDenyAll), enabling more flexible network security management for pod-based load balancing.

  2. New Utility Functions:

    • Case-insensitive string set implementation (pkg/util/sets/) for managing string collections
    • Comprehensive test coverage for utility functions
  3. Configuration Additions:

    • Add PodCidrsIPv4 and PodCidrsIPv6 fields to support pod CIDR configuration
    • Add ServiceGatewayEnabled and related config fields for future service gateway support
    • Add helper methods: IsLBBackendPoolTypePodIP(), UseServiceLoadBalancer(), IsLBBackendPoolTypePodIPAndUseServiceLoadBalancer()
  4. Constants and Templates:

    • Add LoadBalancerSKUService constant for service load balancer SKU
    • Add PodLabelServiceEgressGateway label constant
    • Add NatGatewayIDTemplate for NAT Gateway resource ID formatting
    • Fix capitalization: LoadBalancerBackendPoolConfigurationTypePODIPLoadBalancerBackendPoolConfigurationTypePodIP
  5. Test Infrastructure:

    • Add WithOnlyTCPPorts() and WithOnlyUDPPorts() test fixtures for service testing
    • Add RetainDestinationFromRules() method to security group helper for rule retention logic
    • Comprehensive test coverage for all new functionality (~1,200 new test lines)

This PR is the first in a series that will enable pod IP-based backend pools and the CLB DiffTracker Engine. All changes are backward compatible and do not affect existing functionality.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 19, 2025
@github-actions github-actions bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 19, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 19, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: georgeedward2000
Once this PR has been reviewed and has the lgtm label, please assign nilo19 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @georgeedward2000. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants