Repository navigation
fix: honor --version-bump in the release command - #246
Merged
Merged
Conversation
A workflow that runs ci --no-release and then release forwards its dispatch's --version-bump to both. release resolved the version as auto regardless. A forced bump over commits that all carry [skip ci] opens the version gate in ci, which commits the forced version to VERSION.md, and release then closed the gate again and published nothing. release now takes --version-bump and passes it to version resolution, and its handler takes an options record like ci's.
2 tasks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ktsubuild releaseignored the dispatch's version bump. It always resolved the version asauto. The shared ktsudotnet.ymlrunsci --no-test --no-releaseand thenrelease, and onlycireceives--version-bump. With a forced bump over commits that all carry[skip ci], the two steps disagreed:ciopened the version gate, wrote the forced version to VERSION.md, and committed it.releaseresolved asauto, closed the gate, and published nothing.That happened on 2026-10-14 with patch dispatches on ktsu-dev/GitBranchStateCache and ktsu-dev/GitLfsCache. Each run left an
Update Metadatacommit for 1.0.42 and 1.12.5 on main and loggedSkipping release: All commits contain [skip ci] tag.This PR:
--version-bumptoreleaseand passes it toResolveVersionAsync. The default staysauto, so existing callers are unchanged.releasehandler to take aReleaseOptionsrecord, matchingci'sCiOptions.The shared workflow still has to pass
--version-bumpto itsreleasestep. That's a separate ktsu-dev/.github PR, and it has to merge after this ships, because an olderktsubuildrejects the unknown option.Test plan
ReleaseCommandTests. A forced patch over[skip ci]-only commits cuts and pushesv3.10.1, whileautostill skips and creates no tag.--version-bumpvalidation and itsautodefault matchci.tag -acall.🤖 Generated with Claude Code