Repository navigation
Keep a value slider's number in one color, and name arrows and color plainly - #629
Merged
Merged
Conversation
…d color plainly A fill whose edge fell inside the centred number split it into two colors, dark on the fill and light on the frame. The fill now steps above and below the number wherever an edge would fall under it, as it already did for a fill lying wholly beneath it. KeyChordMatcher.DisplayName writes the arrows as Up, Down, Left and Right, and the gradient editor's hint says color. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YBjmkc8h6q3WWydh9nFrqT
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Matt · project thread
Before: when a value slider's fill ended inside the centered number (any value near 50%, or any bipolar value, whose fill starts at the center), the number was split at the edge: half dark on the fill, half light on the frame ("6|6"). Shortcuts read "Alt+UpArrow", and the gradient editor said "Select a stop to edit its colour".
After: wherever an edge of the fill would fall under the number, the fill steps above and below it, as it already did for a fill lying wholly beneath the number, so the number is always one color. Arrows read "Up", "Down", "Left" and "Right", and the hint says "color".
How:
ValueSliderState.FillAvoidsTextnow answers true whenever either fill edge lies inside the number's box, andDrawClippedcuts the hole only across the number's width, drawing the fill full height either side of it.KeyChordMatcher.DisplayNamenames the arrows;Composeand parsing are unchanged, so saved keymaps still read back.Tests: a UI test (
ValueSlider_AFillEndingUnderTheNumberStepsAroundIt) that fails without the change, updated state and chord tests. Widgets unit (1123), widgets UI (759) and node editor (273) suites pass locally. The widgets demo suite fails locally only because its LFS images aren't pulled in the container.Found by the ImageGui UI review (plans/ui-review-2026-10-12.md, task 1).
🤖 Generated with Claude Code
https://claude.ai/code/session_01YBjmkc8h6q3WWydh9nFrqT
Generated by Claude Code