Repository navigation
[minor] Publish the chord matcher, interface scale, linear colour edits, prompt answers, overwrite confirmation and crop guides - #628
Merged
Conversation
…ts, prompt answers, overwrite confirmation and crop guides ImageGui keeps its own copies of these; this makes ImGuiApp's versions public or adds what was missing so the copies can go. - KeyChordMatcher is public, with TryCapture, Compose, Display and DisplayName - InterfaceScale is public, with Pixels, and answers one without a context - ColorEdit, ColorPicker and ColorButton store linear and show sRGB - Prompt takes PromptButtons with their own probe names and a cancel answer for a dismissal, an optional PromptCheckbox, and runs actions after the popup ends - FilesystemBrowser.ConfirmOverwrite asks before a save replaces a file - CropOverlay draws golden ratio, golden spiral, diagonals, triangles and grid guides through CropOverlayOptions, flippable; CropGuides draws them anywhere Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RJMwk2LEtENDVogQnzKNpW
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
…rawn bounds once in the new tests Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RJMwk2LEtENDVogQnzKNpW
|
This was referenced Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Matt · project thread
Before: ImageGui keeps its own copies of a chord matcher with capture and menu names, the interface scale, hand-written linear-to-sRGB colour edits, a choice dialog, and crop guides, because ImGuiApp's versions are internal or missing.
After: ImGuiApp publishes all of them, so ImageGui can delete its copies (its batch i task 9) without its UI changing.
KeyChordMatcheris public, withTryCapture,Compose(KeyChordModifiers, ImGuiKey),DisplayandDisplayName, using ImageGui'sChordKeystables (Ctrl+],Alt+UpArrow,Superfor Meta).InterfaceScaleis public, gainsPixels, and answers 1 when there is no ImGui context.ImGuiWidgets.ColorEdit/ColorPicker/ColorButtonstore linear and show sRGB, writing back only on an edit.ImGuiPopups.Prompt.OpentakesPromptButtons (own probe name, at most oneIsCancel) and an optionalPromptCheckboxread throughChecked. Actions run after the popup ends, so an answer can open the next prompt. A prompt closed without an answer (Escape, close button, or pushed aside by another popup) runs the cancel action once. EveryModalnow centres itself each time it appears.FilesystemBrowser.ConfirmOverwrite(off by default) asks before a save picks an existing file.CropOverlaygains an overload takingCropOverlayOptions: golden ratio, golden spiral, diagonals, triangles and grid guides, flippable.CropGuidesdraws the same lines over any rectangle or turned crop. The original overload draws the same pixels as before (tested).How: tests for each piece (unit tests for chord naming and round trips, colour conversions and guide geometry; isolation UI tests for capture, colour edits and guides; prompt and overwrite UI tests in the popups suite), demo sections, two gallery tiles (ColorEdit, CropOverlay guides), and README and CLAUDE.md lines. Every test suite and the gallery suite pass locally.
🤖 Generated with Claude Code
https://claude.ai/code/session_01RJMwk2LEtENDVogQnzKNpW
Generated by Claude Code