Repository navigation
[patch] Stop ValueSlider reporting a change on held frames that move nothing - #626
Merged
Merged
Conversation
…nothing A drag is held as a double, and a float slider compared that double with the float it was handed, so a value a float cannot hold exactly read as a fresh change on every frame the pointer rested. Values are now compared as they are stored. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018BGac9LmQV495Bsnrmo1b7
|
This was referenced Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Matt · project thread
Before: holding a float
ValueSliderstill after a drag reported a change on every frame, whenever the dragged value was one a float cannot hold exactly. ImageGui's held straighten never settled because of it, and ImageGui carries a workaround.After: a held pointer that does not move reports no change, and nothing is marked edited.
How: the drag is accumulated as a double, and
SetValuecompared that double with the float it was handed, which differ by float rounding on every frame. It now rounds to the stored type (float or int) before comparing.Tests:
ValueSlider_AHeldPointerThatStopsReportsNoChangedrags 7 px on a 0..1 slider (0.035, not exact in a float) and holds; it fails on main and passes here. The widget suites pass locally.🤖 Generated with Claude Code
https://claude.ai/code/session_018BGac9LmQV495Bsnrmo1b7
Generated by Claude Code