Repository navigation
Compare ValueSlider values bit for bit rather than with Equals - #624
Merged
Merged
Conversation
Sonar's S1244 counts double.Equals as floating-point equality. The question is whether anything wrote a new value, which bits answer exactly. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VX31mmLGVNK3y28fjKiFmB
|
This was referenced Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Matt · project thread
Before: SonarCloud failed #622 on S1244 (floating-point equality), raised on the two places
ValueSlideruseddouble.Equalsto decide whether the value changed. #622 merged before this fix landed on it.After: no behavior change. Those two comparisons go through
IsSameValue, which compares the doubles' bits. That is whatEqualswas doing in effect, and it says so explicitly, so the finding clears.How: one private helper in
ImGui.Widgets/ValueSlider.cs. The ValueSlider UI suite (18 tests) passes locally.🤖 Generated with Claude Code
https://claude.ai/code/session_01VX31mmLGVNK3y28fjKiFmB
Generated by Claude Code