Repository navigation
Draw the History column newest first so clipping drops the oldest runs [patch] - #367
Merged
Merged
Conversation
…s [patch] The column is 80px wide but draws up to five frame-height indicators oldest first, so the two newest runs were clipped off the right edge. Draw them newest first instead, which also holds for a narrower width persisted from an earlier session. The selection moves into SelectHistoryRuns so the order is tested. Fixes #362 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016mc7y8RBT9hdbRWHYe3yxf
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #362
What was wrong
The History column is 80px wide by default, but
ShowBranchHistorydraws up to five frame-height indicators oldest first. Only about three fit, so the column clipped the two newest runs off its right edge. In the gallery, BuildMonitor's running run never appeared.Change
internal static SelectHistoryRuns, so the order can be tested without ImGui.I left the default column width alone. Sizing it from the frame height needs the font at runtime and can't fix a saved width anyway. It can follow separately if it's wanted.
Tests
New
HistoryRunsTestschecks three things: the newest run comes first, only five runs are shown, and canceled runs are skipped. All three fail with the old reversed order. With the change, all 144 tests pass (unit and UI).🤖 Generated with Claude Code
https://claude.ai/code/session_016mc7y8RBT9hdbRWHYe3yxf
Generated by Claude Code