Directive param for centeredSlides#58
Open
alvarosabu wants to merge 1 commit intoksachdeva:masterfrom
alvarosabu:master
Open
Directive param for centeredSlides#58alvarosabu wants to merge 1 commit intoksachdeva:masterfrom alvarosabu:master
alvarosabu wants to merge 1 commit intoksachdeva:masterfrom
alvarosabu:master
Conversation
kbeaugrand
suggested changes
Mar 4, 2017
kbeaugrand
left a comment
There was a problem hiding this comment.
I think I will be better to use real swiper api properties.
I should be preferable to use centeredSlides attribute name rather than centered.
In my opinion, We could use all directive attributes to extends our params like :
link: function(scope, element, attrs) {
...
$scope.params = angular.extend({}, $attrs);
...In this way we could use $scope.params in controller function which will contains all swiper well-named arguments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added param fo directive to setup if the active slider cand be in the center