Add support for method output port splitting#1
Open
krame505 wants to merge 89 commits intokrame505:genwrapfrom
Open
Add support for method output port splitting#1krame505 wants to merge 89 commits intokrame505:genwrapfrom
krame505 wants to merge 89 commits intokrame505:genwrapfrom
Conversation
krame505
commented
Jan 9, 2026
| filterZeroWidthPorts _ _ = error "filterZeroWidthPorts: non-empty port names list" | ||
|
|
||
| -- Helper class to conditionally convert Bit 0 to () | ||
| class NonEmptyBits n pb | n -> pb where |
Owner
Author
There was a problem hiding this comment.
@nanavati thinks this type class should have a different name. I'm unsure what to call it, though - maybeFilterEmptyBits? But that name sort of implies that we are filtering a tuple of Bit ns, while this actually deals with turning just a single Bit n into a ().
…sn't work b/c lambda bodies aren't partially evaluated before iExpandMethod.
…ment construction
krame505
force-pushed
the
split-output-ports
branch
from
d6f158c to
1566d62
Compare
…uses a type lacking a Bit or SplitPorts instance
krame505
force-pushed
the
split-output-ports
branch
from
1566d62 to
500a1d6
Compare
This module only exists so that AAddSchedAssumps can create an AVInst for mkRWire of size 1. We could consider eliminating it by having BSC construct the AVInst in a better way. Until then, the interface is at least unneeded, so remove it -- eliminating the need for RWireN. Also remove vMkUnsafeRWire1, which is unneeded and should not have been created (when adding unsafe versions of the real modules).
It may have been needed for the VModInfo created by vMkRWire1, but that has been removed and testing passes without the change. Plus, VName should not be qualified, so better to catch if we are creating a qualified name somewhere.
krame505
force-pushed
the
split-output-ports
branch
from
58f9b23 to
8ea4ba6
Compare
krame505
force-pushed
the
split-output-ports
branch
from
8ea4ba6 to
76a2d19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is based on the input port splitting branch on my fork of bsc, for the sake of reviewing without seeing the changes from B-Lang-org#729.