Skip to content

Added right click to fields and improved usage for password managers#197

Open
StefanStrategis wants to merge 3 commits into
kou-yeung:masterfrom
StefanStrategis:master
Open

Added right click to fields and improved usage for password managers#197
StefanStrategis wants to merge 3 commits into
kou-yeung:masterfrom
StefanStrategis:master

Conversation

@StefanStrategis

Copy link
Copy Markdown
Contributor

No description provided.

…ds (for right clicks)

- Added option to keep input fields active (for autofill)
- Added option to right click input fields (for manual copy/paste)
}
return instances.push(input) - 1;
},
WebGLInputUpdateRect: function (id, canvasId, x, y, width, height, fontsize, isMultiLine, isMobile){

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fontsize, isMultiLine, and isMobile do not seem to be used here.
If this method is supposed to update only the rect, maybe we should remove these parameters
(or move font-size handling to another method).

}
void IDeselectHandler.OnDeselect(BaseEventData eventData)
{
DeactivateInputField();

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need check keepElementActive for call DeactivateInputField()?
and need add

        void ISelectHandler.OnSelect(BaseEventData eventData)
        {
            if (keepElementActive)
            {
                SyncText();
            }
        }

for sync text ( for issue #194

// モバイルの場合、強制表示する
var isHidden = !(showHtmlElement || Application.isMobilePlatform);
id = WebGLInputPlugin.WebGLInputCreate(WebGLInput.CanvasId, rect.x, rect.y, rect.width, rect.height, fontSize, input.text, input.placeholder, input.lineType != LineType.SingleLine, isPassword, isHidden, Application.isMobilePlatform);
id = WebGLInputPlugin.WebGLInputCreate(WebGLInput.CanvasId, rect.x, rect.y, rect.width, rect.height, fontSize, input.text, input.placeholder, input.lineType != LineType.SingleLine, isPassword, isHidden, false, autoComplete);

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

miss for pass isMobile flag ?
changed Application.isMobilePlatform to false.

@kou-yeung

Copy link
Copy Markdown
Owner

and have some issue.
detail::

After selecting a UI Toolkit element and performing a right-click operation,
for some reason a normal InputField can no longer be selected (edited).
Right-clicking on an empty area restores the ability to select the InputField again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants