fix(wrap-mupdf): prevent integer overflow in allocator#2472
Open
tachibana-shin wants to merge 1 commit into
Open
fix(wrap-mupdf): prevent integer overflow in allocator#2472tachibana-shin wants to merge 1 commit into
tachibana-shin wants to merge 1 commit into
Conversation
my_malloc_default: check 'size > SIZE_MAX - sizeof(header)' before computing 'size + sizeof(header)'. If size is close to SIZE_MAX, the addition wraps to a small value, causing malloc to allocate a tiny buffer while the caller expects a large one — heap buffer overflow.
Frenzie
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
my_malloc_defaultcomputessize + sizeof(header)to allocate extra spacefor its tracking header. If
sizeis close toSIZE_MAX, the addition wrapsto a small value.
mallocsucceeds with a tiny allocation, but the calleroperates as if it received
sizebytes — heap buffer overflowThis change is