Шептихин Вячеслав#278
Open
sheptikhinv wants to merge 7 commits into
Open
Conversation
a-zhelonkin
reviewed
Dec 1, 2025
| return rectangle; | ||
| } | ||
|
|
||
| public ICollection<Rectangle> Rectangles => _rectangles.AsReadOnly(); |
There was a problem hiding this comment.
В интерфейс ICollection "можно" добавить элементы, но в реализации будет ReadOnlyCollection, которая при попытке добавить что-то, бросит ошибку. Нужен какой-нибудь другой "закрытый" интерфейс
a-zhelonkin
reviewed
Dec 3, 2025
| public class CircularCloudLayouterTests | ||
| { | ||
| private CircularCloudLayouter _layouter; | ||
| private Point _center; |
There was a problem hiding this comment.
Вроде бы не нужна на уровне полей класса
| { | ||
| private CircularCloudLayouter _layouter; | ||
| private Point _center; | ||
| private string _testName; |
There was a problem hiding this comment.
Думаю, тоже не нужна, скорее всего можно использовать сразу TestContext.CurrentContext.Test.Name
| private Color GenerateRandomColor() | ||
| { | ||
| return Color.FromArgb( | ||
| _random.Next(256), |
There was a problem hiding this comment.
Т.к. каких-то специфичных настроек для генератора не требуется, можно использовать Random.Shared
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.